Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for killing other pieces #158

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Write tests for killing other pieces #158

merged 5 commits into from
Jan 23, 2024

Conversation

Monkey-bored
Copy link
Collaborator

Solved Issues [#154] and [#153]

@Monkey-bored Monkey-bored linked an issue Jan 23, 2024 that may be closed by this pull request
Write tests for killing other pieces #154
Closed
5 tasks
@Monkey-bored Monkey-bored mentioned this pull request Jan 23, 2024
Closed
@Ido-Barnea Ido-Barnea changed the title 154 write tests for killing other pieces Write tests for killing other pieces Jan 23, 2024
Ido-Barnea
Ido-Barnea requested changes Jan 23, 2024
View reviewed changes
Copy link
Owner

@Ido-Barnea Ido-Barnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

development/code/logic/pieces/Bishop.test.ts Outdated Show resolved Hide resolved
development/code/logic/pieces/Bishop.test.ts Outdated Show resolved Hide resolved
development/code/logic/pieces/Pawn.test.ts Outdated Show resolved Hide resolved
development/code/logic/pieces/Pawn.test.ts Outdated Show resolved Hide resolved
development/code/logic/pieces/Pawn.test.ts Outdated Show resolved Hide resolved
development/code/logic/pieces/Rook.test.ts Outdated Show resolved Hide resolved
development/code/logic/pieces/Rook.test.ts Outdated Show resolved Hide resolved
development/code/logic/pieces/King.test.ts Outdated Show resolved Hide resolved
development/code/logic/pieces/Bishop.test.ts Outdated Show resolved Hide resolved
development/code/logic/pieces/Knight.test.ts Outdated Show resolved Hide resolved
Ido-Barnea
Ido-Barnea approved these changes Jan 23, 2024
View reviewed changes
Copy link
Owner

@Ido-Barnea Ido-Barnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <{•.•}>

@Monkey-bored Monkey-bored merged commit 0a52a40 into master Jan 23, 2024
4 checks passed
@Monkey-bored Monkey-bored deleted the 154-write-tests-for-killing-other-pieces branch January 23, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ido-Barnea Ido-Barnea Ido-Barnea approved these changes

Assignees

@Monkey-bored Monkey-bored

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write tests for killing other pieces
2 participants
@Monkey-bored @Ido-Barnea