Initial shop logic

.eslintrc.json

@@ -47,7 +47,7 @@
         "caughtErrorsIgnorePattern": "_"
       }
     ],
-    "no-unneeded-ternary": ["error"],
+    "no-unneeded-ternary": ["warn"],
     "max-len": [
       "warn",
       {
@@ -56,8 +56,8 @@
         "ignoreStrings": true
       }
     ],
-    "comma-dangle": ["error", "always-multiline"],
-    "camelcase": ["error"],
+    "comma-dangle": ["warn", "always-multiline"],
+    "camelcase": ["warn"],
     "no-constant-condition": "off"
   }
 }

development/code/LogicAdapter.ts

@@ -71,7 +71,7 @@ export function onActionTriggered(
     onPlayerAction(draggedPiece, targetPiece);
   } else if (targetElement.classList.contains('item')) {
     game.getItems().forEach((item) => {
-      if (item.position && comparePositions(item.position, targetElementPosition)) {
+      if (comparePositions(item.position, targetElementPosition)) {
         onPlayerAction(draggedPiece, item);
       }
     });

development/code/logic/PieceLogic.ts

@@ -25,7 +25,7 @@ function validatePlayerAction(
   if (draggedPiece.position.boardId !== target.position?.boardId) return false;
 
   const legalMoves = draggedPiece.getLegalMoves();
-  return legalMoves.some(position => target.position && comparePositions(position, target.position));
+  return legalMoves.some(position => comparePositions(position, target.position));
 }
 
 function getPathPositions(start: Position, end: Position): Array<Position> {
@@ -56,7 +56,7 @@ function simulatePath(piece: Piece, targetPosition: Position) {
 
   pathPositions.forEach(position => {
     game.getItems().forEach(item => {
-      if (item.position && comparePositions(item.position, position)) {
+      if (comparePositions(item.position, position)) {
         onActionPieceToItem(piece, item);
       }
     });
@@ -251,7 +251,7 @@ function handlePieceSpawning(targetPiece: Piece) {
   });
 
   game.getItems().forEach((item) => {
-    if (item.position && comparePositions(targetPiece.position, item.position)) {
+    if (comparePositions(targetPiece.position, item.position)) {
       onActionPieceToItem(targetPiece, item);
     }
   });

development/code/logic/Utilities.ts

@@ -3,9 +3,11 @@ import { Piece } from './pieces/Pieces';
 import { Position } from './pieces/PiecesUtilities';
 
 export function comparePositions(
-  firstPosition: Position,
-  secondPosition: Position,
+  firstPosition: Position | undefined,
+  secondPosition: Position | undefined,
 ): boolean {
+  if (!firstPosition|| !secondPosition) return false;
+
   const arePositionsEqual =
     firstPosition.coordinates[0] === secondPosition.coordinates[0] &&
     firstPosition.coordinates[1] === secondPosition.coordinates[1];

development/code/logic/pieces/PiecesUtilities.ts

@@ -26,6 +26,6 @@ export interface PieceType {
 export function getItemByPosition(
   position: Position,
 ): Item | undefined {
-  return game.getItems().find((item) => item.position && comparePositions(position, item.position));
+  return game.getItems().find((item) => comparePositions(position, item.position));
 }