Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#109] Added inventory UI #187

Merged
merged 16 commits into from
Feb 14, 2024
Merged

[#109] Added inventory UI #187

merged 16 commits into from
Feb 14, 2024

Conversation

Monkey-bored
Copy link
Collaborator

That was something.

@Monkey-bored Monkey-bored self-assigned this Feb 14, 2024
@Ido-Barnea Ido-Barnea self-requested a review February 14, 2024 17:26
Ido-Barnea
Ido-Barnea requested changes Feb 14, 2024
View reviewed changes
Copy link
Owner

@Ido-Barnea Ido-Barnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See requested changes

development/code/Game.ts Show resolved Hide resolved
development/code/Game.ts Outdated Show resolved Hide resolved
development/code/Game.ts Outdated Show resolved Hide resolved
development/code/LogicAdapter.ts Outdated Show resolved Hide resolved
development/code/logic/items/Inventory.ts Outdated Show resolved Hide resolved
development/code/ui/Events.ts Show resolved Hide resolved
development/code/ui/Events.ts Outdated Show resolved Hide resolved
development/code/ui/Events.ts Outdated Show resolved Hide resolved
development/code/ui/InventoriesUI.ts Outdated Show resolved Hide resolved
development/code/ui/InventoriesUI.ts Outdated Show resolved Hide resolved
Ido-Barnea
Ido-Barnea requested changes Feb 14, 2024
View reviewed changes
Copy link
Owner

@Ido-Barnea Ido-Barnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change and we're good :)

development/code/ui/Events.ts Outdated Show resolved Hide resolved
Ido-Barnea
Ido-Barnea requested changes Feb 14, 2024
View reviewed changes
development/code/Game.ts Outdated Show resolved Hide resolved
development/code/Game.ts Outdated Show resolved Hide resolved
development/code/ui/Events.ts Outdated Show resolved Hide resolved
Ido-Barnea
Ido-Barnea approved these changes Feb 14, 2024
View reviewed changes
Copy link
Owner

@Ido-Barnea Ido-Barnea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ඞ ඞ ඞ ඞ ඞ ඞ ඞ
LGTM
ඞ ඞ ඞ ඞ ඞ ඞ ඞ

@Monkey-bored Monkey-bored merged commit 3d283cb into master Feb 14, 2024
3 of 4 checks passed
@Monkey-bored Monkey-bored deleted the backup-backup-109 branch February 14, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ido-Barnea Ido-Barnea Ido-Barnea approved these changes

Assignees

@Monkey-bored Monkey-bored

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Monkey-bored @Ido-Barnea