Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#249] Fixed upgrading piece twice bug #284

Conversation

Monkey-bored
Copy link
Collaborator

Does this fix hurt the separation between the UI and the Logic? Maybe, but we might have to rework this file entirely for that.

@Monkey-bored Monkey-bored self-assigned this Apr 7, 2024
@Monkey-bored Monkey-bored linked an issue Apr 7, 2024 that may be closed by this pull request
Copy link
Owner

@Ido-Barnea Ido-Barnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Monkey-bored
Copy link
Collaborator Author

LGTM

No emojis?! 😭😭😭😭😭

@Monkey-bored Monkey-bored merged commit e94280b into master Apr 7, 2024
3 checks passed
@Monkey-bored Monkey-bored deleted the 249-xp-decreases-despite-piece-already-having-been-upgraded branch April 7, 2024 19:50
@Ido-Barnea
Copy link
Owner

LGTM

No emojis?! 😭😭😭😭😭

🫠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XP Decreases Despite Piece Already Having Been Upgraded
2 participants