Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color code the logs #85

Closed
wants to merge 9 commits into from
Closed

Color code the logs #85

wants to merge 9 commits into from

Conversation

Omoorion
Copy link
Collaborator

No description provided.

@Omoorion Omoorion linked an issue Oct 29, 2023 that may be closed by this pull request
Color code the logs #65
Closed
@Omoorion Omoorion requested a review from Ido-Barnea October 29, 2023 11:09
Ido-Barnea
Ido-Barnea requested changes Oct 29, 2023
View reviewed changes
Copy link
Owner

@Ido-Barnea Ido-Barnea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the linting and color code "fell off the board" to the same red as "killed..." 😃

Ido-Barnea
Ido-Barnea requested changes Oct 30, 2023
View reviewed changes
Copy link
Owner

@Ido-Barnea Ido-Barnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, the issue you faced with the formatter made you change a bunch of files that shouldn't have changed and the linter doesn't seem to check them.

.github/workflows/checkin.yml Outdated Show resolved Hide resolved
.github/workflows/commit-message-checker.yml Outdated Show resolved Hide resolved
.github/workflows/commit-message-checker.yml Outdated Show resolved Hide resolved
.github/workflows/commit-message-checker.yml Outdated Show resolved Hide resolved
.github/workflows/commit-message-checker.yml Outdated Show resolved Hide resolved
.github/workflows/style-checker.yml Outdated Show resolved Hide resolved
LICENSE.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Ido-Barnea Ido-Barnea changed the title 65 color code the logs Color code the logs Oct 30, 2023
Ido-Barnea
Ido-Barnea requested changes Oct 30, 2023
View reviewed changes
development/src/logger.ts Outdated Show resolved Hide resolved
Ido-Barnea
Ido-Barnea requested changes Oct 31, 2023
View reviewed changes
development/views/index.html Outdated Show resolved Hide resolved
jest.config.ts Outdated Show resolved Hide resolved
Ido-Barnea
Ido-Barnea requested changes Oct 31, 2023
View reviewed changes
index.html Outdated Show resolved Hide resolved
Ido-Barnea
Ido-Barnea requested changes Oct 31, 2023
View reviewed changes
development/src/logger.ts Outdated Show resolved Hide resolved
@Omoorion Omoorion requested a review from Ido-Barnea November 1, 2023 07:28
@Ido-Barnea Ido-Barnea closed this Nov 7, 2023
@Ido-Barnea Ido-Barnea deleted the 65-color-code-the-logs branch November 7, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ido-Barnea Ido-Barnea Awaiting requested review from Ido-Barnea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color code the logs
2 participants
@Omoorion @Ido-Barnea