-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move page loading progress bar around the refresh button #1010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. @felipeerias how does it fit with your UI revamp plans?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we cannot enable it because surprisingly it does not work in all the platforms we support. I noticed that it's broken in Pico
ScreenRecording.mp4See what it looks like in Pico |
That's interesting, looks like they have customized the ProgressBar there |
f3860ce
to
0c8ae80
Compare
Added the animation to rotate the progress bar, can you help me test in Pico and see what does it look like? @svillar |
This is how it looks now ScreenRecording.mp4two comments:
I guess 1. is because Pico's android version. Not sure if we can do something about 2. In the other devices it still looks great |
Yeah, maybe it's because of Pico's Android version, which leads to Pico's ProgressBar looking different than others. For 2, of course, we can modify the duration here to make it faster, but this will also make the progressBar look even faster (since it's already rotating there). Since I don't have a Pico device, I don't know what will be the best parameter here to fine-tune the UI effect so that we can have the optimal on all the devices. https://github.com/Igalia/wolvic/pull/1010/files#diff-74e9484af8eff0bd67f1eab07581f9f10496f9e26bf5e7a467b8885155823657R9 |
The address bar is hidden in kiosk mode, so we should have the progress bar somewhere else. Also, it's not a good idea to have a loading view inserted before url text, which can cause distraction as the position of the URL text can keep changing. Resolve #299 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
0c8ae80
to
083db04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land this then as @felipeerias is OK with it (confirmed offline)
The address bar is hidden in kiosk mode, so we should have the progress bar somewhere else.
Also, it's not a good idea to have a loading view inserted before url text, which can cause distraction as the position of the URL text can keep changing.
Resolve #299
com.igalia.wolvic-20230925-001354.mp4