Move homepage URL to a resValue in build config #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're removing it from the list of non translatable strings. Having it in the build config allows us to specify different start pages per flavour. In this case we're interested in providing a different one for the Chinese market as some of the experiences in the start page cannot be either viewed from mainland China or simply take a lot to load. So far we're using about:blank but we can change that in the future.
svillar
force-pushed
the
homepage-china
branch
from
da321a7
to
be3a4d4
Compare
HollowMan6
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're removing it from the list of non translatable strings. Having it in the build config allows us to specify different start pages per flavour. In this case we're interested in providing a different one for the Chinese market as some of the experiences in the start page cannot be either viewed from mainland China or simply take a lot to load.
So far we're using about:blank but we can change that in the future.