[HVR] Fix flavor detection when deciding about requesting SSID #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HollowMan6
suggested changes
Sep 27, 2023
We've recently added some code for HVR in China that was meant to prevent Wolvic to call getSSID() because that's considered recollection of personal data even if we only use it to show the SSID in the UI. The problem is that we were comparing the lowercase name of the flavor with "mainlandChina" with capital C, so this was obviously never matching. Correct that and also replace the displayed tooltip text from "unknown" to "unavailable" which is more precise.
👍 thanks for letting me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently added some code for HVR in China that was meant to prevent Wolvic to call getSSID() because that's considered recollection of personal data even if we only use it to show the SSID in the UI.
The problem is that we were comparing the lowercase name of the flavor with "mainlandChina" with capital C, so this was obviously never matching. Correct that and also replace the default english translation from "unknown" to "unavailable" which is more precise.