Use the widget name from widget placement #1628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WidgetPlacement structure contains the name of the widget. When building the name for the native widgets we were using a combination of "Widget-" prefix + the widget handle. That was not useful at all for debugging as it was not possible to differentiate between widgets by name. Instead it's much better to use the widget name that is passed in WidgetPlacement. That way we can identify whether a widget is a TrayWidget, a WindowWidget... We keep the widget handle in the name as it's useful to differentiate widgets that may have multiple instances (like Windows for example).
felipeerias
requested changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WidgetPlacement structure contains the name of the widget. When building the name for the native widgets we were using a combination of "Widget-" prefix + the widget handle. That was not useful at all for debugging as it was not possible to differentiate between widgets by name.
Instead it's much better to use the widget name that is passed in WidgetPlacement. That way we can identify whether a widget is a TrayWidget, a WindowWidget... We keep the widget handle in the name as it's useful to differentiate widgets that may have multiple instances (like Windows for example).