Skip to content

fix(cell): improve local cell detection logic #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damyanpetev merged 1 commit into from
Jan 23, 2026
Merged

fix(cell): improve local cell detection logic #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/components/cell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,15 @@ export default class IgcGridLiteCell<T extends object> extends LitElement {
/**
* The parent row component holding this cell.
*/
@property({ attribute: false })
public row!: IgcGridLiteRow<T>;

@property({ attribute: false })
public rowIndex = -1;

@property({ attribute: false })
public cellTemplate?: (context: IgcCellContext<T>) => unknown;

protected get context(): IgcCellContext<T> {
return {
parent: this,
Expand All @@ -56,8 +63,8 @@ export default class IgcGridLiteCell<T extends object> extends LitElement {

protected override render() {
return html`${cache(
this.column.cellTemplate
? this.column.cellTemplate(this.context as any)
this.cellTemplate
? this.cellTemplate(this.context as any)
: html`<span part="text">${this.value}</span>`
)}`;
}
Expand Down
2 changes: 2 additions & 0 deletions src/components/row.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ export default class IgcGridLiteRow<T extends object> extends LitElement {
part="cell"
.active=${key === column.field && index === this.index}
.column=${column}
.cellTemplate=${column.cellTemplate}
.row=${this as IgcGridLiteRow<T>}
.rowIndex=${this.index}
.value=${resolveFieldValue(data, column.field)}
></igc-grid-lite-cell>`
)}
Expand Down