Skip to content

Conversation

@damyanpetev
Copy link
Member

No description provided.

@damyanpetev damyanpetev requested a review from Copilot January 27, 2026 14:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes type inference issues by adding recursion depth limits and excluding built-in types from DotPaths traversal. The changes prevent excessive type recursion and avoid attempting to traverse JavaScript built-in objects that shouldn't be decomposed into dot-notation paths.

Changes:

  • Added NonTraversable union type to exclude built-in types (functions, arrays, dates, etc.)
  • Implemented depth-limiting mechanism using Prev tuple type to cap recursion at 5 levels
  • Updated DotPaths type to check depth and non-traversable types before recursing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link

coveralls commented Jan 29, 2026

Pull Request Test Coverage Report for Build 21473213785

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.006%

Totals Coverage Status
Change from base Build 21292650237: 0.0%
Covered Lines: 2944
Relevant Lines: 2984

💛 - Coveralls

@damyanpetev damyanpetev requested a review from Copilot January 29, 2026 09:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@damyanpetev damyanpetev marked this pull request as ready for review January 29, 2026 10:21
@rkaraivanov rkaraivanov merged commit 77607da into master Jan 29, 2026
5 checks passed
@rkaraivanov rkaraivanov deleted the dpetev/dot-path-type-fix branch January 29, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants