refactor(grids): change button text in column pinning both side samples #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates button labels in column pinning samples to better clarify that the actions apply to selected columns rather than a single column. The changes improve user experience by making button functionality more explicit.
Key Changes:
- Updated button text from "Unpin Column" to "Unpin Selected Columns"
- Updated button text from "Pin Left/Right" to "Pin Selected Left/Right"
- Standardized quote usage in
getElementByIdcalls
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| samples/grids/tree-grid/column-pinning-both-sides/src/index.tsx | Updated button labels to indicate they operate on selected columns and standardized quotes |
| samples/grids/hierarchical-grid/column-pinning-both-sides/src/index.tsx | Updated button labels to indicate they operate on selected columns and standardized quotes |
| samples/grids/grid/column-pinning-both-sides/src/index.tsx | Updated button labels to indicate they operate on selected columns and standardized quotes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3784