Update Datatables.php

Big fix to get_total_results function. This passed the years and nobody realised that this function was counting all the records on selects, consuming huge amounts of memory (sometimes throwing OUT OF MEMORY) when working with big tables, and giving the impression the pagination was not working.
IgnitedDatatables · Feb 8, 2017 · 85ebb6a · 85ebb6a
1 parent 943e058
commit 85ebb6a
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/application/libraries/Datatables.php b/application/libraries/Datatables.php
@@ -449,9 +449,12 @@ private function get_total_results($filtering = FALSE)
         $this->ci->db->distinct($this->distinct);
         $this->ci->db->select($this->columns);
       }
-
-      $query = $this->ci->db->get($this->table, NULL, NULL, FALSE);
-      return $query->num_rows();
+      $subquery = $this->ci->db->get_compiled_select($this->table);
+      $countingsql = "SELECT COUNT(*) FROM (" . $subquery . ") SqueryAux";
+      $query = $this->ci->db->query($countingsql);
+      $result = $query->row_array();
+      $count = $result['COUNT(*)'];
+      return $count;
     }
 
     /**