Brought back a condition check in the lock (App-vNext#1290)

IgorIgorevich94 · Aug 26, 2023 · d8ccdd8 · d8ccdd8
1 parent 59b6133
commit d8ccdd8
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/Polly/CircuitBreaker/CircuitStateController.cs b/src/Polly/CircuitBreaker/CircuitStateController.cs
@@ -38,11 +38,13 @@ public CircuitState CircuitState
 
             using var _ = TimedLock.Lock(_lock);
 
-            if (!IsInAutomatedBreak_NeedsLock)
+#pragma warning disable CA1508 // Avoid dead conditional code. _circuitState is checked again in the lock
+            if (_circuitState == CircuitState.Open && !IsInAutomatedBreak_NeedsLock)
             {
                 _circuitState = CircuitState.HalfOpen;
                 _onHalfOpen();
             }
+#pragma warning restore CA1508 // Avoid dead conditional code. _circuitState is checked again in the lock
 
             return _circuitState;
         }