-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always define compact #86
Conversation
I can't see why the build failed in Travis. Any clues? |
Fix build by pinning node-sass dependency (used indirectly via gulp-sass) to v3.4.x until Igosuki/compass-mixins#86 is resolved.
The transition mixin has always been broken in Sass. I've updated so it now works as expected on both Node Sass and Sass. |
This implement of compact is functionally equivalent of the unofficial native one that has been permanently removed from LibSass. There is no risk in always using this version. The version of LibSass that had a `compact` function is extremely difficult to obtain, and is long unsupported. More importantly defining function inside control structures is not valid in Sass and produces errors for people using this library. Fixes Igosuki#84 Fixes Igosuki#85
Yes please can this be merged? Refs: clappr/clappr#970 |
FYI I've created a fork with this fix: https://github.com/tjenkinson/compass-mixins (because it looks like this might not be maintained anymore). |
This is a blocker for me, I have fixed my initial issue by installing node-sass 3.7.0 but this remains. Is this going to get merged and released? |
@Igosuki please merge these, many projects depend on it, thank you |
Agreed with @phazei. I don't know why |
As far as node-sass is concerned it wasn't a breaking change. You can read
|
@shri3k yes I just did
https://www.npmjs.com/package/tjenkinson-compass-mixins Hopefully this will start being maintained again though. |
@xzyfer Ah, that sort of clarifies things. |
@xzyfer Thank you for merging. I'm confirming that this works. 🎉 |
This implement of compact is functionally equivalent of the
unofficial native one that has been permanently removed from LibSass.
There is no risk in always using this version. The version of LibSass
that had a
compact
function is extremely difficult to obtain, andis long unsupported.
More importantly defining function inside control structures is not
valid in Sass and produces errors for people using this library.
Closes #73
Fixes #84
Fixes #85