Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alertLowWine.py #293

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

morecs
Copy link
Contributor

@morecs morecs commented Jan 11, 2025

Update.
Now the list with alerted city will be clear after 24h. This was needed because after first alert on one city, that city will not get alerted anymore.
Minor fix and improve of the overall code.

@ikagod
Copy link
Collaborator

ikagod commented Jan 12, 2025

Will there be more commits made to this PR?

@morecs
Copy link
Contributor Author

morecs commented Jan 12, 2025

At this time no. But until the next update to the version 7.1.0 i`ll have some updates on the module. There for this pull request is still in draft

@ElieTaillard ElieTaillard added this to the 7.1.2 milestone Jan 18, 2025
@ikagod ikagod modified the milestones: 7.1.2, 7.2.0 Jan 19, 2025
@morecs morecs marked this pull request as ready for review January 19, 2025 17:08
@morecs
Copy link
Contributor Author

morecs commented Jan 20, 2025

This module can be mearged to the master. Small improve to the alerted list. Modify msg when setting up the alert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants