This repository was archived by the owner on Mar 5, 2024. It is now read-only.
Improve speed of package installation #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
approved these changes
Jun 20, 2023
|
This looks great to me! @jgwerner think you can add me as a collaborator here, so I can help maintain this? |
|
I've merged this PR into my fork (https://github.com/yuvipanda/jupyter-pluto-proxy) and made a couple other improvements! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Julia package installation step used to precompile everything multiple times. After this PR, all packages are installed at once which avoids precompiling multiple times. This will speed up the build by a minute or so.
Also, I've moved the
RUNstatement beforeCOPY . "${HOME}/app". When a file inside the local directory (.) changes, Docker will rerun all steps after that from scratch. Since the Julia package installation step doesn't depend on the files inside the directory, the statement can be moved up. This will speed up developer build time when changing files.