Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add download study button #109

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

pedrokohler
Copy link
Collaborator

@pedrokohler pedrokohler commented Oct 17, 2024

Adding button to download study/series:

image

Solves #110

@pedrokohler
Copy link
Collaborator Author

@fedorov please take a look

@fedorov
Copy link
Member

fedorov commented Oct 18, 2024

Looks good to me, thank you!

@pedrokohler I assume, similar to OHIF, it is not trivial to hyperlink idc-index in this popup, right?

@pedrokohler
Copy link
Collaborator Author

Looks good to me, thank you!

@pedrokohler I assume, similar to OHIF, it is not trivial to hyperlink idc-index in this popup, right?

It's the same thing: doable in an hour or so, because the content of the dialog is variable, so we must parse the config strings to display the hyperlink.

@fedorov
Copy link
Member

fedorov commented Oct 18, 2024

Let's go ahead as is then! We can address both at a later time to add hyperlink processing.

Copy link
Collaborator

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igoroctaviano igoroctaviano merged commit bd430c9 into master Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants