draco_bbox: Use cerr for error messages. And use more specific exit codes.#1
Open
birgerbr wants to merge 1 commit intobbox-croppingfrom
Open
draco_bbox: Use cerr for error messages. And use more specific exit codes.#1birgerbr wants to merge 1 commit intobbox-croppingfrom
birgerbr wants to merge 1 commit intobbox-croppingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A typical error with this application is the
NoOverlapcase, which usually is due to a mismatch of the coordinate systems of the point cloud (.ply) and the mesh (.drc).By writing the error message to
std::cerrand returning more specific exit-codes the user of this application (python code in bim-alignment-sintef or background-worker) can either throw an exception and use thestd::cerrin the message as default, and create custom exceptions for specific exit-codes. For example, withExitCode::NoOverLap, the python code could tell the user to check the manifest.json