Use ValidationError in tests

ImperialCollegeLondon · Jan 17, 2024 · b21da1c · b21da1c
1 parent 9443b12
commit b21da1c
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/tests/measurement/test_models.py b/tests/measurement/test_models.py
@@ -1,6 +1,7 @@
 from datetime import datetime
 
 import pytz
+from django.core.exceptions import ValidationError
 from django.test import TestCase
 from model_bakery import baker
 
@@ -149,7 +150,7 @@ def test_clean_validation(self):
         # If becomes inactive but is not validated, there's an error
         self.model.is_validated = False
         self.model.is_active = False
-        with self.assertRaises(ValueError):
+        with self.assertRaises(ValidationError):
             self.model.clean()
 
         # If it is inactive but has been validated, then it is ok again
@@ -167,17 +168,17 @@ def test_clean_reporting(self):
         # If either is false, then it cannot be used
         self.model.is_validated = True
         self.model.is_active = False
-        with self.assertRaises(ValueError):
+        with self.assertRaises(ValidationError):
             self.model.clean()
 
         self.model.is_validated = False
         self.model.is_active = True
-        with self.assertRaises(ValueError):
+        with self.assertRaises(ValidationError):
             self.model.clean()
 
         self.model.is_validated = False
         self.model.is_active = False
-        with self.assertRaises(ValueError):
+        with self.assertRaises(ValidationError):
             self.model.clean()
 
     def test_overwritten(self):