Set up project with django-plotly-dash #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmbland
changed the title
|
Not sure why the tests are failing? @dalonsoa |
CWestICL
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Other than the failing tests, all looks good to me! Tested on my PC and it works as expected.
Not sure why the tests are failing either, looks like a migration issue but you haven't changed any of the models. Hopefully @dalonsoa has some insight
|
I can reproduce the error by simply running |
dalonsoa
reviewed
Jan 30, 2024
There was a problem hiding this comment.
OK, the problem is that when launching the app for the first time, there's no data in the database. As the daily_validation code is executed when the application is launched for the first time rather than when the page is loaded, there's not time to populate the db, and things crash. This is not going to be a problem in the real scenario, obviously, but it is now during development.
For you, this has worked because you already had the database populated, but in the GH Actions or in my laptop, in a totally fresh installation, it breaks.
Would my suggestion work, loading the problematic code only when the relevant view is loaded?
validated/urls.py
Outdated
| @@ -15,6 +15,7 @@ | |||
| from rest_framework.urlpatterns import format_suffix_patterns | |||
|
|
|||
| from . import views | |||
| from .dash_apps.finished_apps import daily_validation | |||
There was a problem hiding this comment.
Why do you import daily_validation here?
| @@ -426,6 +427,11 @@ def post(self, request, *args, **kwargs): | |||
| return render(request, "home/message.html", {"message": form}) | |||
|
|
|||
|
|
|||
| class DailyValidationDev(View): | |||
| def get(self, request, *args, **kwargs): | |||
| return render(request, "daily_validation_dev.html") | |||
There was a problem hiding this comment.
Import the validation stuff here:
Suggested change
| return render(request, "daily_validation_dev.html") | |
| from .dash_apps.finished_apps import daily_validation | |
| return render(request, "daily_validation_dev.html") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes to the repo to get it set up with django-plotly-dash
I've created a minimal dash app accessible at http://localhost:8000/validated/daily_validation_dev/ which for now just consists of a single graph, just to see how everything is done. This will need to be added to and eventually integrated into the main page (the dev url/view should then be deleted). I am going to use this as a starting point for #121, and a similar approach could be used for #120
(I've also used github copilot to add docstrings and comments to the javascript code to make it easier for me to understand. However in the long run we are planning to get rid of this code anyway.)
Close #135