Fix copyright attributions #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user is putting their code on the `ImperialCollegeLondon` GitHub org they probably should be attributing the copyright to ICL, but I'm not sure it's worth the effort of adding another prompt for this. In any case, it certainly shouldn't be attributed to me, so let's fix that.
alexdewar
requested review from
dalonsoa,
cc-a and
AdrianDAlessandro
as code owners
AdrianDAlessandro
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AdrianDAlessandro has pointed out that the copyright for the repo and for anything generated from the template is attributed to me personally. For the repo, it should be attributed to ICL.
Users of the template may want to attribute it to ICL too (but they won't want to attribute it to me!). It seemed like unnecessary hassle to add another prompt about this though, so I just changed it to use the author's name, which is probably also fine for most cases.
Fixes #84.