Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on workflow call #156

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Run CI on workflow call #156

merged 1 commit into from
Oct 29, 2024

Conversation

AdrianDAlessandro
Copy link
Contributor

@AdrianDAlessandro AdrianDAlessandro commented Oct 29, 2024

Description

The docs.yml workflow currently requires the test job in ci.yml, but that is not callable from another workflow. This fixes that.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

The docs.yml workflow currently requires the `test` job in ci.yml, but that is not callable from another workflow. This fixes that.
@AdrianDAlessandro AdrianDAlessandro merged commit f83cb8d into main Oct 29, 2024
9 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the ci-on-workflow-call branch October 29, 2024 15:47
@alexdewar
Copy link
Collaborator

Good spot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants