Replace prettier hook with separate formatters for YAML and JSON #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdewar
requested review from
dalonsoa,
cc-a and
AdrianDAlessandro
as code owners
AdrianDAlessandro
approved these changes
Aug 5, 2024
| schedule: | ||
| interval: "weekly" | ||
| interval: weekly |
There was a problem hiding this comment.
Does this still work fine? Slightly annoying it's changing Dependabot's defaults / recommended format.
There was a problem hiding this comment.
Yup! It's equivalent.
I'd probs rather have the double quotes too, but I can't be bothered to fight the formatter over it. Couldn't see an option for changing the quote type 😞
There was a problem hiding this comment.
We should strive for a state of zen that allows us to accept whatever the formatter says is best.
cc-a
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fiddled with the settings so that the JSON and YAML output looks similar to what we had before. I still think
prettierdid a better job in places, but this is good enough!Fixes #52.