Add option to make RSE team co-author #69
Conversation
Currently it's just added by default, which users who aren't part of the RSE team probably won't want.
alexdewar
requested review from
dalonsoa,
cc-a and
AdrianDAlessandro
as code owners
| @@ -4,8 +4,10 @@ name = "{{ cookiecutter.project_slug }}" | |||
| version = "0.1.0" | |||
| description = "{{ cookiecutter.project_description }}" | |||
| authors = [ | |||
| "{{ cookiecutter.author }} <{{ cookiecutter.author_email }}>", | |||
| "{{ cookiecutter.author }} <{{ cookiecutter.author_email }}>" | |||
There was a problem hiding this comment.
I suspect we're going to need a comma here
| "{{ cookiecutter.author }} <{{ cookiecutter.author_email }}>" | |
| "{{ cookiecutter.author }} <{{ cookiecutter.author_email }}>", |
There was a problem hiding this comment.
We don't actually need a comma, because one's added on the line below.
There was a problem hiding this comment.
Oh I see, I did miss that. Won't that format really weirdly? It seems like it will be a single, unindented line with one comma in it? Like:
uthors = [
"Author <mail@mail.com>"
,
"Imperial College London RSE Team <ict-rse-team@imperial.ac.uk>"
]There was a problem hiding this comment.
Weirdly not. If you start your jinja block with <%- rather than just <% it trims the whitespace before it, so you can have it on a new line (similarly if you put -%> at the end it'll trim the whitespace after).
We don't have to do it this way though if you think it's more readable to have the if on the previous line.
There was a problem hiding this comment.
We don't have to do it this way though if you think it's more readable to have the
ifon the previous line.
Sorry, I missed this reply. No, it's not more or less readable, I just saw the if had been removed previously.
| @@ -28,8 +30,10 @@ name = "{{ cookiecutter.project_slug }}" | |||
| version = "0.1.0" | |||
| description = "{{ cookiecutter.project_description }}" | |||
| authors = [ | |||
| { name = "{{ cookiecutter.author }}", email = "{{ cookiecutter.author_email }}" }, | |||
| { name = "{{ cookiecutter.author }}", email = "{{ cookiecutter.author_email }}" } | |||
There was a problem hiding this comment.
And here
| { name = "{{ cookiecutter.author }}", email = "{{ cookiecutter.author_email }}" } | |
| { name = "{{ cookiecutter.author }}", email = "{{ cookiecutter.author_email }}" }, |
Currently it's just added by default, which users who aren't part of the RSE team probably won't want.
We do usually want to list the RSE team as a co-author, so I think this is useful for us. That said, it's debateable whether we want another
cookiecutteroption for it or to just have it commented out inpyproject.toml. I think either way is fine.