Remove comments system for tags - really not useful. #11
Conversation
There was a problem hiding this comment.
I don't see how any comments could have been added to a tag or category, so no need to worry about orphaned records in the database.
There are some additional references to comments - here's one in tag.php
if ($icmsModuleConfig['com_rule'] && $tagObj->getVar('tag_cancomment')) {
$icmsTpl->assign('imtagging_tag_comment', true);
include_once ICMS_ROOT_PATH . '/include/comment_view.php';
}
| function imtagging_db_upgrade_2() { | ||
| $icmsDatabaseUpdater = icms_db_legacy_Factory::getDatabaseUpdater(); | ||
| //$icmsDatabaseUpdater->; | ||
| $sql = sprintf("ALTER TABLE %s DROP column tag_cancomment", icms::$xoopsDB->prefix('imtagging_tag')); |
There was a problem hiding this comment.
I wonder if the upgrade method handles this without having to explicitly do this. See icms_db_legacy_updater_Handler::upgradeObjectItem().
There was a problem hiding this comment.
It does - I just removed the 2 lines in class/tag.php for tag_cancomment and updated the module. That was enough to drop the column.
There was a problem hiding this comment.
Great! that makes version updates considerably easier, at least when it comes to removing fields.
| 'title' => '_MI_IMTAGGING_LIMIT', | ||
| 'description' => '_MI_IMTAGGING_LIMITDSC', | ||
| 'title' => _MI_IMTAGGING_LIMIT, | ||
| 'description' => _MI_IMTAGGING_LIMITDSC, | ||
| 'formtype' => 'textbox', | ||
| 'valuetype' => 'text', | ||
| 'default' => 5); | ||
|
|
There was a problem hiding this comment.
When I added config items to imBlogging, the language constants did need to be enclosed in quotes to be treated as a constant.
There was a problem hiding this comment.
that is correct, error on my part.
closes #5