Skip to content

Fix type registry conversions #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GhostofCookie merged 2 commits into from
Jan 10, 2025
Merged

Fix type registry conversions #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0156054
Fix complete or variadic conversions only using the first conversion …
GhostofCookie Jan 10, 2025
245e84a
Adding back some functionality but keeping the bug fix.
GhostofCookie Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions include/flow/core/NodeFactory.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,16 @@ class NodeFactory
{
}

template<typename>
void RegisterUnidirectionalConversion()
{
}

template<typename>
void RegisterBidirectionalConversion()
{
}

public:
/**
* @brief Event dispatcher that runs every time a new node class is registered.
Expand Down Expand Up @@ -293,15 +303,15 @@ template<typename From, typename To, typename... Ts>
void NodeFactory::RegisterUnidirectionalConversion(const TypeRegistry::ConversionFunc& converter)
{
_conversion_registry.RegisterUnidirectionalConversion<From, To>(converter);
(_conversion_registry.RegisterUnidirectionalConversion<From, Ts>(converter), ...);
RegisterUnidirectionalConversion<From, Ts...>();
}

template<typename From, typename To, typename... Ts>
void NodeFactory::RegisterBidirectionalConversion(const TypeRegistry::ConversionFunc& from_to_converter,
const TypeRegistry::ConversionFunc& to_from_converter)
{
_conversion_registry.RegisterBidirectionalConversion<From, To>(from_to_converter, to_from_converter);
(_conversion_registry.RegisterBidirectionalConversion<From, Ts>(from_to_converter, to_from_converter), ...);
RegisterBidirectionalConversion<From, Ts...>();
}

template<typename From, typename To, typename... Ts>
Expand Down
Loading