Skip to content
This repository was archived by the owner on Jun 10, 2019. It is now read-only.

Fix for issue #146 #147

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix for issue #146 #147

wants to merge 1 commit into from

Conversation

@kanevbg
Copy link

@kanevbg kanevbg commented Jul 13, 2018

No description provided.

@jacquesbh
Copy link

SGTM

@jacquesbh
Copy link

Actually @kanevbg a better approach could be this instead:

try {
    session_module_name($moduleName);
} catch (\Throwable $e) {}

jacquesbh
jacquesbh suggested changes Sep 10, 2018
View reviewed changes
Copy link

@jacquesbh jacquesbh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

Also the update of modman is missing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jacquesbh jacquesbh jacquesbh requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kanevbg @jacquesbh