-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Persistent User Data #1617
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pathParamsType: 'object', | ||
dataReturnType: 'full', | ||
}), | ||
// pluginTanstackQuery({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case we want to access api endpoints which are public from the frontend this can be useful, but of course, we can just write it with a useQuery as well.
* update github workflow to include generate * update docs
…x-app into feat/persistent-user-data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
@@ -56,7 +56,7 @@ export interface TokenContext { | |||
onSelectLeverageType: (type: LeverageType) => void | |||
onSelectOutputToken: (tokenSymbol: string) => void | |||
reset: () => void | |||
toggleIsMinting: () => void | |||
toggleIsMinting: (force?: boolean) => void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this force
used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure atm, but I wanted to have an option at some point to explicitly set this, because in certain cases toggle will not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great 🔥 - few tiny nits
package.json
Outdated
@@ -34,16 +35,18 @@ | |||
"@safe-global/api-kit": "2.5.4", | |||
"@safe-global/protocol-kit": "4.0.4", | |||
"@safe-global/safe-core-sdk-types": "5.0.3", | |||
"@sentry/cli": "2.40.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this dep used somewhere, or was it for testing something/can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes good catch, i can remove it I was just experimenting with the mess of failing vercel builds
) | ||
} | ||
|
||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could update to return <></>
if it's the idiomatic way in react-table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore, this review in the other pr please: #1731
@@ -93,6 +93,7 @@ export default function Page() { | |||
</div> | |||
<div className='flex flex-col gap-6 lg:flex-row'> | |||
<div className='h-full w-full lg:min-w-[67%] lg:max-w-[67%]'> | |||
{/* <PortfolioWidget /> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something that will be added soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the new YourTokens basically
Summary of Changes
Added APIv2 integration, and persistent user entity, + persisted trades
YourTokens is rewritten into PortfolioWidget, but for now the old YourTokens is kept, with the old leverage/history endpoint rendamed to legacy-history, as the behavior has changed.
SessionStorage usage for refId is added.
Test Data or Screenshots
By submitting this pull request, you are confirming the following to be true:
IndexCoop/index-app
.