TeddySwap Integration #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sluder
commented
Nov 30, 2023
Sluder
commented
Nov 30, 2023
pblake81239
reviewed
Dec 1, 2023
Sluder
commented
Dec 1, 2023
src/dex/teddyswap.ts
Outdated
| } | ||
|
|
||
| const relevantAssets = utxo.assetBalances.filter((assetBalance) => { | ||
| const assetName = (assetBalance.asset as Asset).assetName; |
There was a problem hiding this comment.
Suggested change
| const assetName = (assetBalance.asset as Asset).assetName; | |
| const assetName = assetBalance.asset === 'lovelace' ? 'lovelace' : assetBalance.assetName; |
There was a problem hiding this comment.
: assetBalance.asset.assetName;
Is asset not required here?
There was a problem hiding this comment.
Yes it is! My comment was wrong but the code reflects the correct path now
|
Nice! 🚀 |
pblake81239
reviewed
Dec 14, 2023
Sluder
commented
Dec 14, 2023
| @@ -100,6 +109,20 @@ export class DefinitionBuilder { | |||
| * Recursively pull parameters from datum using definition template. | |||
| */ | |||
| private extractParameters(definedDefinition: DefinitionField, templateDefinition: DefinitionField, foundParameters: DatumParameters = {}): DatumParameters { | |||
| if (templateDefinition instanceof Function) { | |||
There was a problem hiding this comment.
Adds support for datum mappings to include dynamic pulling/pushing of parameters. One example would be an order datum not including a stake key, which will result in a different datum. Not all DEXs support this atm, but will push a fix after this PR is in
Sluder
commented
Dec 14, 2023
| quantity: batcherFee?.value + deposit.value, | ||
| }, | ||
| ], | ||
| datum: datumBuilder.getCbor(), |
ItsDaveB
reviewed
Dec 14, 2023
| @@ -210,6 +210,7 @@ export class Minswap extends BaseDex { | |||
| }, | |||
| ], | |||
| datum: datumBuilder.getCbor(), | |||
| isInlineDatum: false, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.