Closed
Conversation
PanZezhong1725
force-pushed
the
frontend-api
branch
from
1bab2fb to
9b7fc3e
Compare
PanZezhong1725
force-pushed
the
frontend-api
branch
2 times, most recently
from
df05e0c to
3763a43
Compare
Contributor
|
比较多文件缺少尾随空行 |
YdrMaster
suggested changes
Jan 24, 2024
|
|
||
| key_states = self.transpose(key_states, [0, 1, 3, 2]) | ||
| if self.num_kv_groups > 1: | ||
| attn_weights = self.matmul_group_k(query_states, key_states) |
Contributor
There was a problem hiding this comment.
实际上全部使用 group matmul 的逻辑就行了，reshape 不产生计算，没有开销
| else: | ||
| attn_weights = self.matmul(query_states, key_states) | ||
|
|
||
| attn_weights = self.div( |
| attn_weights = self.add(attn_weights, attention_mask) | ||
|
|
||
| if self.dtype != DTYPE.F32: | ||
| attn_weights = self.cast(attn_weights, DTYPE.F32) |
Contributor
There was a problem hiding this comment.
这里可以一直 cast，类型不变的 cast 会被跳过，不会计算
YdrMaster
force-pushed
the
dev
branch
2 times, most recently
from
9acbb3c to
594e06b
Compare
PanZezhong1725
force-pushed
the
frontend-api
branch
from
18addd0 to
293e98b
Compare
YdrMaster
force-pushed
the
frontend-api
branch
from
af45b67 to
75a0f87
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.