Skip to content

Conversation

@Misterio77
Copy link
Contributor

@Misterio77 Misterio77 commented May 28, 2025

Hi! This adds a couple of additional templates/examples. Both are common usecases, so would benefit with an example.

@Misterio77 Misterio77 force-pushed the push-yvxmlpzvtsot branch from e5cfb42 to bc89ffa Compare May 28, 2025 16:15
@Misterio77 Misterio77 force-pushed the push-yvxmlpzvtsot branch from bc89ffa to 84c7cb3 Compare May 31, 2025 19:42
@Misterio77 Misterio77 changed the title add velocity-network and forge-modpack templates add velocity-network and gtnh-modpack templates May 31, 2025
Copy link
Owner

@Infinidoge Infinidoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to run all of the files through nixfmt (rfc style)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I really dislike this.

There isn't really a much better way to do it, but I just really dislike it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally not a big fan of overlays either, I just copied these from the other templates haha.

We could pass the input and use nix-minecraft.packages.${pkgs.system} instead. Would you prefer that approach?

Copy link
Owner

@Infinidoge Infinidoge Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I more so mean I really dislike having to make an entire package and custom classpath to run the modpack.

I don't think modpack-specific packages belong in nix-minecraft due to the maintenance burden, but having it as a template is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants