-
Notifications
You must be signed in to change notification settings - Fork 72
tools/minecraftctl: init #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9482333 to
adf430f
Compare
Infinidoge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not personally sure if a minecraftctl is within scope for nix-minecraft, so I'm not sure if this will be accepted as a feature in general. If there are examples of management interfaces like this in Nixpkgs, please let me know where.
With regards to the implementation itself:
- Avoid relying on and parsing names as "canonical" information. Instead, add needed metadata to the packages themselves.
getPackageInfoshould be replaced with relevant metadata inpassthruon the original derivations. - I really do not think bash is the right language for this. I will grant, this is in part due to my dislike of anything moderately complex being written in bash. Needing to reinvent several wheels is... not great.
- Instead of using an environment variable, create a symlink in
/run/minecraft/servers.jsonas a static path. Since this requires a rebuild anyways, - I don't think this needs a spec.
|
@Infinidoge I found this as an example of adding a CLI helper for easier maintenance: https://search.nixos.org/options?channel=unstable&show=services.borgbackup.jobs
as well as agenix (although agenix is not in nixpkgs). For the implementation part, I'm rewriting it in python. |
240a0da to
9b13b54
Compare
fbc1219 to
87b2b63
Compare
87b2b63 to
7c1c758
Compare
7c1c758 to
82ee633
Compare
|
I think it's ready for review! |
This PR adds a CLI Tool for managing and monitoring nix-minecraft servers.
closes #166
Features
System Expectation
it expects: