Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #1121

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Refactor tests #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfe28e1
refactor: Move and group event builders and event extension methods
jvandaal Oct 23, 2023
2715c88
refactor: simplify tests
jvandaal Oct 26, 2023
630d707
Merge branch 'main' into refactor-tests
jvandaal Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AddressRegistry/StreetName/Exceptions/AddressAlreadyExistsException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public sealed class AddressAlreadyExistsException : AddressRegistryException
public AddressAlreadyExistsException()
{ }

public AddressAlreadyExistsException(HouseNumber houseNumber, BoxNumber boxNumber)
public AddressAlreadyExistsException(HouseNumber houseNumber, BoxNumber? boxNumber)
: base($"Address with housenumber '{houseNumber}' and boxnumber '{boxNumber}' already exists.")
{ }

Expand Down
25 changes: 0 additions & 25 deletions test/AddressRegistry.Tests/AggregateTests/EventExtensions/StreetNameWasImportedExtensions.cs
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions ...AddressRegistry.Tests/AggregateTests/Legacy/WhenImportHouseNumberFromCrab/GivenAddress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ namespace AddressRegistry.Tests.AggregateTests.Legacy.WhenImportHouseNumberFromC
using Address.Events;
using AutoFixture;
using Be.Vlaanderen.Basisregisters.Crab;
using EventExtensions;
using global::AutoFixture;
using Xunit;
using Xunit.Abstractions;
Expand Down
1 change: 1 addition & 0 deletions ...try.Tests/AggregateTests/Legacy/WhenImportHouseNumberFromCrab/GivenAddressWithPosition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ namespace AddressRegistry.Tests.AggregateTests.Legacy.WhenImportHouseNumberFromC
using Address.Events.Crab;
using AutoFixture;
using Be.Vlaanderen.Basisregisters.Crab;
using EventExtensions;
using global::AutoFixture;
using NodaTime;
using Xunit;
Expand Down
1 change: 1 addition & 0 deletions ...istry.Tests/AggregateTests/Legacy/WhenImportHouseNumberMailCantonFromCrab/GivenAddress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace AddressRegistry.Tests.AggregateTests.Legacy.WhenImportHouseNumberMailC
using AutoFixture;
using Be.Vlaanderen.Basisregisters.Crab;
using Be.Vlaanderen.Basisregisters.GrAr.Provenance;
using EventExtensions;
using global::AutoFixture;
using Xunit;
using Xunit.Abstractions;
Expand Down
1 change: 1 addition & 0 deletions ...egistry.Tests/AggregateTests/Legacy/WhenImportHouseNumberPositionFromCrab/GivenAddress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ namespace AddressRegistry.Tests.AggregateTests.Legacy.WhenImportHouseNumberPosit
using Be.Vlaanderen.Basisregisters.AggregateSource.Testing;
using Be.Vlaanderen.Basisregisters.Crab;
using Be.Vlaanderen.Basisregisters.GrAr.Provenance;
using EventExtensions;
using global::AutoFixture;
using NodaTime;
using Xunit;
Expand Down
1 change: 1 addition & 0 deletions ...sRegistry.Tests/AggregateTests/Legacy/WhenImportHouseNumberStatusFromCrab/GivenAddress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ namespace AddressRegistry.Tests.AggregateTests.Legacy.WhenImportHouseNumberStatu
using AutoFixture;
using Be.Vlaanderen.Basisregisters.AggregateSource.Testing;
using Be.Vlaanderen.Basisregisters.Crab;
using EventExtensions;
using NodaTime;
using WhenImportHousenumberStatusFromCrab;
using Xunit;
Expand Down
1 change: 1 addition & 0 deletions ...Registry.Tests/AggregateTests/Legacy/WhenImportSubaddressPositionFromCrab/GivenAddress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ namespace AddressRegistry.Tests.AggregateTests.Legacy.WhenImportSubaddressPositi
using Be.Vlaanderen.Basisregisters.AggregateSource.Testing;
using Be.Vlaanderen.Basisregisters.Crab;
using Be.Vlaanderen.Basisregisters.GrAr.Provenance;
using EventExtensions;
using global::AutoFixture;
using NodaTime;
using Xunit;
Expand Down
1 change: 1 addition & 0 deletions ...ssRegistry.Tests/AggregateTests/Legacy/WhenImportSubaddressStatusFromCrab/GivenAddress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ namespace AddressRegistry.Tests.AggregateTests.Legacy.WhenImportSubaddressStatus
using AutoFixture;
using Be.Vlaanderen.Basisregisters.AggregateSource.Testing;
using Be.Vlaanderen.Basisregisters.Crab;
using EventExtensions;
using NodaTime;
using Xunit;
using Xunit.Abstractions;
Expand Down
Loading
Loading