Cli project features #337
Open
Cli project features #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added more conditions and appropriate messages
on secrets deletion to check:
- if provided secret_id is a valid uuid4;
- if secret with provided secret_id is exists.
* Stylystic fixes.
* Removed redundant code to get projects list in `handlers/project.py` file which duplicated `handlers/projects/project.py`; * Updated `project_model` schema to have also `public` field; * When returning project from query, return `public` field also.
* On project deletion:
- validate project id before executing anything with it;
- check if project with provided id exists.
ib-steffen
requested changes
May 13, 2018
| @@ -20,7 +20,7 @@ def test_collaborators_root(self): | |||
| r = TestClient.post('api/v1/projects/%s/collaborators' % self.project_id, | |||
| data=self.test_collaborator_data, | |||
| headers=TestClient.get_user_authorization(self.user_id)) | |||
| self.assertEqual(r['message'], 'Successfully added user') | |||
| self.assertEqual(r['message'], 'Successfully added user.') | |||
There was a problem hiding this comment.
I added this to keep consistency across the code. Since some requests return with dot at the end and some without. We can consider to remove dots at the end everywhere, but always add a dot in the logger.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR is required by InfraBox/cli#34 CLI improvements.
Take a look at this, please.
Best regards,
Kirill Abramov.