Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Commit

Permalink
Release 5.1.0.
Browse files Browse the repository at this point in the history
  • Loading branch information
IngenicoEPayments authored and jenkins committed May 19, 2020
1 parent b8728c5 commit 5f1adb4
Show file tree
Hide file tree
Showing 105 changed files with 1,427 additions and 174 deletions.
2 changes: 1 addition & 1 deletion IngenicoConnectSDK.podspec
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Pod::Spec.new do |s|

s.name = "IngenicoConnectSDK"
s.version = "5.0.0"
s.version = "5.1.0"
s.summary = "Ingenico Connect iOS SDK"
s.description = <<-DESC
This native iOS SDK facilitates handling payments in your apps
Expand Down
4 changes: 4 additions & 0 deletions IngenicoConnectSDK.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@
B4D77F1A1DE731D300F7B1C1 /* ICBasicPaymentProductGroup.h in Headers */ = {isa = PBXBuildFile; fileRef = B4D77EDA1DE731D300F7B1C1 /* ICBasicPaymentProductGroup.h */; settings = {ATTRIBUTES = (Public, ); }; };
B4D77F1B1DE731D300F7B1C1 /* ICPaymentProductNetworks.h in Headers */ = {isa = PBXBuildFile; fileRef = B4D77EDB1DE731D300F7B1C1 /* ICPaymentProductNetworks.h */; settings = {ATTRIBUTES = (Public, ); }; };
B4D77F1C1DE731D300F7B1C1 /* ICPaymentProductNetworks.m in Sources */ = {isa = PBXBuildFile; fileRef = B4D77EDC1DE731D300F7B1C1 /* ICPaymentProductNetworks.m */; };
B91B3F1D245085F300678F89 /* ICC2SCommunicatorTestCase.m in Sources */ = {isa = PBXBuildFile; fileRef = B91B3F1B2450859800678F89 /* ICC2SCommunicatorTestCase.m */; };
B91E15FE241FADF200E28E4B /* ICNetworkingActivityLogger.m in Sources */ = {isa = PBXBuildFile; fileRef = B91E15FD241FADF200E28E4B /* ICNetworkingActivityLogger.m */; };
B9BEFF452422B69E00D5039D /* ICAFNetworkingWrapper.h in Headers */ = {isa = PBXBuildFile; fileRef = B9BEFF442422B69900D5039D /* ICAFNetworkingWrapper.h */; };
B9BEFF462422B6A600D5039D /* ICNetworkingActivityLogger.h in Headers */ = {isa = PBXBuildFile; fileRef = B91E15FF241FAE5C00E28E4B /* ICNetworkingActivityLogger.h */; };
Expand Down Expand Up @@ -493,6 +494,7 @@
B4D77EDA1DE731D300F7B1C1 /* ICBasicPaymentProductGroup.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ICBasicPaymentProductGroup.h; sourceTree = "<group>"; };
B4D77EDB1DE731D300F7B1C1 /* ICPaymentProductNetworks.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ICPaymentProductNetworks.h; sourceTree = "<group>"; };
B4D77EDC1DE731D300F7B1C1 /* ICPaymentProductNetworks.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ICPaymentProductNetworks.m; sourceTree = "<group>"; };
B91B3F1B2450859800678F89 /* ICC2SCommunicatorTestCase.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; name = ICC2SCommunicatorTestCase.m; path = IngenicoConnectSDKTests/ICC2SCommunicatorTestCase.m; sourceTree = "<group>"; };
B91E15FD241FADF200E28E4B /* ICNetworkingActivityLogger.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = ICNetworkingActivityLogger.m; sourceTree = "<group>"; };
B91E15FF241FAE5C00E28E4B /* ICNetworkingActivityLogger.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ICNetworkingActivityLogger.h; sourceTree = "<group>"; };
B9BEFF442422B69900D5039D /* ICAFNetworkingWrapper.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ICAFNetworkingWrapper.h; sourceTree = "<group>"; };
Expand Down Expand Up @@ -699,6 +701,7 @@
B4C369AE1DE754C100C50450 /* Converters */,
B4C369C01DE754C100C50450 /* Models */,
B4C369C81DE754C100C50450 /* Supporting Files */,
B91B3F1B2450859800678F89 /* ICC2SCommunicatorTestCase.m */,
B4C369EE1DE866E300C50450 /* ICC2SCommunicatorConfigurationTestCase.m */,
B4C369EF1DE866E300C50450 /* ICUtilTestCase.m */,
B4C369F01DE866E300C50450 /* IngenicoConnectSDKTests-Bridging-Header.h */,
Expand Down Expand Up @@ -1428,6 +1431,7 @@
B4C369CD1DE754C100C50450 /* ICJSONTestCase.m in Sources */,
B4C369E31DE754C100C50450 /* ICValidatorLuhnTestCase.m in Sources */,
B4C369D41DE754C100C50450 /* ICPaymentGroupConverterTestCase.m in Sources */,
B91B3F1D245085F300678F89 /* ICC2SCommunicatorTestCase.m in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down
13 changes: 11 additions & 2 deletions IngenicoConnectSDK/ICC2SCommunicator.m
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,7 @@ - (void)publicKey:(void (^)(ICPublicKeyResponse *publicKeyResponse))success fail
- (void)paymentProductIdByPartialCreditCardNumber:(NSString *)partialCreditCardNumber context:(ICPaymentContext *)context success:(void (^)(ICIINDetailsResponse *iinDetailsResponse))success failure:(void (^)(NSError *error))failure {
NSString *URL = [NSString stringWithFormat:@"%@/%@/services/getIINdetails", [self baseURL], self.configuration.customerId];

int max = (int) MIN(partialCreditCardNumber.length, 6);
NSString *trimmedPartialCreditCardNumber = [partialCreditCardNumber substringToIndex:max];
NSString *trimmedPartialCreditCardNumber = [self getIINDigitsFrom:partialCreditCardNumber];

NSDictionary *parameters;
ICPaymentContextConverter *converter = [[ICPaymentContextConverter alloc] init];
Expand All @@ -263,7 +262,17 @@ - (void)paymentProductIdByPartialCreditCardNumber:(NSString *)partialCreditCardN
} failure:^(NSError *error) {
failure(error);
}];
}

- (NSString *)getIINDigitsFrom:(NSString *)partialCreditCardNumber {
int max;
if (partialCreditCardNumber.length >= 8) {
max = 8;
}
else {
max = (int) MIN(partialCreditCardNumber.length, 6);
}
return [partialCreditCardNumber substringToIndex:max];
}

- (void)convertAmount:(long)amountInCents withSource:(NSString *)source target:(NSString *)target success:(void (^)(long convertedAmountInCents))success failure:(void (^)(NSError *error))failure
Expand Down
2 changes: 1 addition & 1 deletion IngenicoConnectSDK/ICUtil.m
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ - (instancetype)init
NSString *deviceType = [self deviceType];
self.metaInfo = @{
@"platformIdentifier": platformIdentifier,
@"sdkIdentifier": @"iOSClientSDK/v5.0.0",
@"sdkIdentifier": @"iOSClientSDK/v5.1.0",
@"sdkCreator": @"Ingenico",
@"screenSize": screenSize,
@"deviceBrand": @"Apple",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@
"gc.general.paymentProductFields.validationErrors.range.label" = "يرجى تحديد قيمة محصورة بين {minValue} و{maxValue}";
"gc.general.paymentProductFields.validationErrors.regularExpression.label" = "يرجى تحديد قيمة التنسيق الصحيح";
"gc.general.paymentProductFields.validationErrors.required.label" = "يرجى تحديد قيمة";
"gc.general.paymentProductFields.validationErrors.residentIdName" = "يرجى تحديد قيمة التنسيق الصحيح";
"gc.general.paymentProductFields.validationErrors.residentIdNumber" = "يرجى تحديد قيمة التنسيق الصحيح";
"gc.general.paymentProductFields.validationErrors.residentIdName.label" = "يرجى تحديد قيمة التنسيق الصحيح";
"gc.general.paymentProductFields.validationErrors.residentIdNumber.label" = "يرجى تحديد قيمة التنسيق الصحيح";
"gc.general.paymentProductFields.validationErrors.termsAndConditions.label" = "يرجى قبول الشروط والأحكام";
"gc.general.paymentProductFields.zip.label" = "الرمز البريدي";
"gc.general.paymentProductFields.zip.placeholder" = "الرمز البريدي";
Expand Down Expand Up @@ -434,6 +434,20 @@
"gc.general.paymentProducts.871.name" = "GCash";
"gc.general.paymentProducts.880.name" = "SafetyPay Banking";
"gc.general.paymentProducts.882.name" = "NetBanking";
"gc.general.paymentProducts.884.name" = "FPX";
"gc.general.paymentProducts.885.name" = "Maybank2u";
"gc.general.paymentProducts.886.name" = "CIMB Clicks";
"gc.general.paymentProducts.887.name" = "Bank Islam";
"gc.general.paymentProducts.888.name" = "RHB Now";
"gc.general.paymentProducts.889.name" = "AmOnline";
"gc.general.paymentProducts.890.name" = "Hong Leong Connect";
"gc.general.paymentProducts.891.name" = "PEx+ by HLBB";
"gc.general.paymentProducts.892.name" = "Affin Bank";
"gc.general.paymentProducts.893.name" = "Bangkok Bank";
"gc.general.paymentProducts.894.name" = "Krung Thai Bank";
"gc.general.paymentProducts.895.name" = "Siam Commercial Bank";
"gc.general.paymentProducts.896.name" = "Krungsri e_payment";
"gc.general.paymentProducts.897.name" = "Dragonpay RealTime";
"gc.general.paymentProducts.9000.name" = "أقساط AfterPay";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.label" = "أنا أوافق على شروط وأحكام {link}";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.link.label" = "AfterPay";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@
"gc.general.paymentProductFields.validationErrors.range.label" = "يرجى تحديد قيمة محصورة بين {minValue} و{maxValue}";
"gc.general.paymentProductFields.validationErrors.regularExpression.label" = "يرجى تحديد قيمة التنسيق الصحيح";
"gc.general.paymentProductFields.validationErrors.required.label" = "يرجى تحديد قيمة";
"gc.general.paymentProductFields.validationErrors.residentIdName" = "يرجى تحديد قيمة التنسيق الصحيح";
"gc.general.paymentProductFields.validationErrors.residentIdNumber" = "يرجى تحديد قيمة التنسيق الصحيح";
"gc.general.paymentProductFields.validationErrors.residentIdName.label" = "يرجى تحديد قيمة التنسيق الصحيح";
"gc.general.paymentProductFields.validationErrors.residentIdNumber.label" = "يرجى تحديد قيمة التنسيق الصحيح";
"gc.general.paymentProductFields.validationErrors.termsAndConditions.label" = "يرجى قبول الشروط والأحكام";
"gc.general.paymentProductFields.zip.label" = "الرمز البريدي";
"gc.general.paymentProductFields.zip.placeholder" = "الرمز البريدي";
Expand Down Expand Up @@ -434,6 +434,20 @@
"gc.general.paymentProducts.871.name" = "GCash";
"gc.general.paymentProducts.880.name" = "SafetyPay Banking";
"gc.general.paymentProducts.882.name" = "NetBanking";
"gc.general.paymentProducts.884.name" = "FPX";
"gc.general.paymentProducts.885.name" = "Maybank2u";
"gc.general.paymentProducts.886.name" = "CIMB Clicks";
"gc.general.paymentProducts.887.name" = "Bank Islam";
"gc.general.paymentProducts.888.name" = "RHB Now";
"gc.general.paymentProducts.889.name" = "AmOnline";
"gc.general.paymentProducts.890.name" = "Hong Leong Connect";
"gc.general.paymentProducts.891.name" = "PEx+ by HLBB";
"gc.general.paymentProducts.892.name" = "Affin Bank";
"gc.general.paymentProducts.893.name" = "Bangkok Bank";
"gc.general.paymentProducts.894.name" = "Krung Thai Bank";
"gc.general.paymentProducts.895.name" = "Siam Commercial Bank";
"gc.general.paymentProducts.896.name" = "Krungsri e_payment";
"gc.general.paymentProducts.897.name" = "Dragonpay RealTime";
"gc.general.paymentProducts.9000.name" = "أقساط AfterPay";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.label" = "أنا أوافق على شروط وأحكام {link}";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.link.label" = "AfterPay";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@
"gc.general.paymentProductFields.validationErrors.range.label" = "Zadejte hodnotu mezi {minValue} a {maxValue}";
"gc.general.paymentProductFields.validationErrors.regularExpression.label" = "Zadejte hodnotu ve správném formátu";
"gc.general.paymentProductFields.validationErrors.required.label" = "Zadejte hodnotu";
"gc.general.paymentProductFields.validationErrors.residentIdName" = "Zadejte hodnotu ve správném formátu";
"gc.general.paymentProductFields.validationErrors.residentIdNumber" = "Zadejte hodnotu ve správném formátu";
"gc.general.paymentProductFields.validationErrors.residentIdName.label" = "Zadejte hodnotu ve správném formátu";
"gc.general.paymentProductFields.validationErrors.residentIdNumber.label" = "Zadejte hodnotu ve správném formátu";
"gc.general.paymentProductFields.validationErrors.termsAndConditions.label" = "Přijměte prosím podmínky a ujednání";
"gc.general.paymentProductFields.zip.label" = "PSČ";
"gc.general.paymentProductFields.zip.placeholder" = "PSČ";
Expand Down Expand Up @@ -434,6 +434,20 @@
"gc.general.paymentProducts.871.name" = "GCash";
"gc.general.paymentProducts.880.name" = "SafetyPay Banking";
"gc.general.paymentProducts.882.name" = "NetBanking";
"gc.general.paymentProducts.884.name" = "FPX";
"gc.general.paymentProducts.885.name" = "Maybank2u";
"gc.general.paymentProducts.886.name" = "CIMB Clicks";
"gc.general.paymentProducts.887.name" = "Bank Islam";
"gc.general.paymentProducts.888.name" = "RHB Now";
"gc.general.paymentProducts.889.name" = "AmOnline";
"gc.general.paymentProducts.890.name" = "Hong Leong Connect";
"gc.general.paymentProducts.891.name" = "PEx+ by HLBB";
"gc.general.paymentProducts.892.name" = "Affin Bank";
"gc.general.paymentProducts.893.name" = "Bangkok Bank";
"gc.general.paymentProducts.894.name" = "Krung Thai Bank";
"gc.general.paymentProducts.895.name" = "Siam Commercial Bank";
"gc.general.paymentProducts.896.name" = "Krungsri e_payment";
"gc.general.paymentProducts.897.name" = "Dragonpay RealTime";
"gc.general.paymentProducts.9000.name" = "Splátky AfterPay";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.label" = "Souhlasím s obchodními podmínkami a pravidly {link}";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.link.label" = "AfterPay";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@
"gc.general.paymentProductFields.validationErrors.range.label" = "Zadejte hodnotu mezi {minValue} a {maxValue}";
"gc.general.paymentProductFields.validationErrors.regularExpression.label" = "Zadejte hodnotu ve správném formátu";
"gc.general.paymentProductFields.validationErrors.required.label" = "Zadejte hodnotu";
"gc.general.paymentProductFields.validationErrors.residentIdName" = "Zadejte hodnotu ve správném formátu";
"gc.general.paymentProductFields.validationErrors.residentIdNumber" = "Zadejte hodnotu ve správném formátu";
"gc.general.paymentProductFields.validationErrors.residentIdName.label" = "Zadejte hodnotu ve správném formátu";
"gc.general.paymentProductFields.validationErrors.residentIdNumber.label" = "Zadejte hodnotu ve správném formátu";
"gc.general.paymentProductFields.validationErrors.termsAndConditions.label" = "Přijměte prosím podmínky a ujednání";
"gc.general.paymentProductFields.zip.label" = "PSČ";
"gc.general.paymentProductFields.zip.placeholder" = "PSČ";
Expand Down Expand Up @@ -434,6 +434,20 @@
"gc.general.paymentProducts.871.name" = "GCash";
"gc.general.paymentProducts.880.name" = "SafetyPay Banking";
"gc.general.paymentProducts.882.name" = "NetBanking";
"gc.general.paymentProducts.884.name" = "FPX";
"gc.general.paymentProducts.885.name" = "Maybank2u";
"gc.general.paymentProducts.886.name" = "CIMB Clicks";
"gc.general.paymentProducts.887.name" = "Bank Islam";
"gc.general.paymentProducts.888.name" = "RHB Now";
"gc.general.paymentProducts.889.name" = "AmOnline";
"gc.general.paymentProducts.890.name" = "Hong Leong Connect";
"gc.general.paymentProducts.891.name" = "PEx+ by HLBB";
"gc.general.paymentProducts.892.name" = "Affin Bank";
"gc.general.paymentProducts.893.name" = "Bangkok Bank";
"gc.general.paymentProducts.894.name" = "Krung Thai Bank";
"gc.general.paymentProducts.895.name" = "Siam Commercial Bank";
"gc.general.paymentProducts.896.name" = "Krungsri e_payment";
"gc.general.paymentProducts.897.name" = "Dragonpay RealTime";
"gc.general.paymentProducts.9000.name" = "Splátky AfterPay";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.label" = "Souhlasím s obchodními podmínkami a pravidly {link}";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.link.label" = "AfterPay";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@
"gc.general.paymentProductFields.validationErrors.range.label" = "Angiv en værdi mellem {minValue} og {maxValue}";
"gc.general.paymentProductFields.validationErrors.regularExpression.label" = "Angiv en værdi i det korrekte format";
"gc.general.paymentProductFields.validationErrors.required.label" = "Angiv en værdi";
"gc.general.paymentProductFields.validationErrors.residentIdName" = "Angiv en værdi i det korrekte format";
"gc.general.paymentProductFields.validationErrors.residentIdNumber" = "Angiv en værdi i det korrekte format";
"gc.general.paymentProductFields.validationErrors.residentIdName.label" = "Angiv en værdi i det korrekte format";
"gc.general.paymentProductFields.validationErrors.residentIdNumber.label" = "Angiv en værdi i det korrekte format";
"gc.general.paymentProductFields.validationErrors.termsAndConditions.label" = "Du bedes acceptere vores vilkår og betingelser";
"gc.general.paymentProductFields.zip.label" = "Postnummer";
"gc.general.paymentProductFields.zip.placeholder" = "Postnummer";
Expand Down Expand Up @@ -434,6 +434,20 @@
"gc.general.paymentProducts.871.name" = "GCash";
"gc.general.paymentProducts.880.name" = "SafetyPay Banking";
"gc.general.paymentProducts.882.name" = "NetBanking";
"gc.general.paymentProducts.884.name" = "FPX";
"gc.general.paymentProducts.885.name" = "Maybank2u";
"gc.general.paymentProducts.886.name" = "CIMB Clicks";
"gc.general.paymentProducts.887.name" = "Bank Islam";
"gc.general.paymentProducts.888.name" = "RHB Now";
"gc.general.paymentProducts.889.name" = "AmOnline";
"gc.general.paymentProducts.890.name" = "Hong Leong Connect";
"gc.general.paymentProducts.891.name" = "PEx+ by HLBB";
"gc.general.paymentProducts.892.name" = "Affin Bank";
"gc.general.paymentProducts.893.name" = "Bangkok Bank";
"gc.general.paymentProducts.894.name" = "Krung Thai Bank";
"gc.general.paymentProducts.895.name" = "Siam Commercial Bank";
"gc.general.paymentProducts.896.name" = "Krungsri e_payment";
"gc.general.paymentProducts.897.name" = "Dragonpay RealTime";
"gc.general.paymentProducts.9000.name" = "AfterPay rater";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.label" = "Jeg accepterer {link} vilkår og betingelser";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.link.label" = "AfterPay";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@
"gc.general.paymentProductFields.validationErrors.range.label" = "Angiv en værdi mellem {minValue} og {maxValue}";
"gc.general.paymentProductFields.validationErrors.regularExpression.label" = "Angiv en værdi i det korrekte format";
"gc.general.paymentProductFields.validationErrors.required.label" = "Angiv en værdi";
"gc.general.paymentProductFields.validationErrors.residentIdName" = "Angiv en værdi i det korrekte format";
"gc.general.paymentProductFields.validationErrors.residentIdNumber" = "Angiv en værdi i det korrekte format";
"gc.general.paymentProductFields.validationErrors.residentIdName.label" = "Angiv en værdi i det korrekte format";
"gc.general.paymentProductFields.validationErrors.residentIdNumber.label" = "Angiv en værdi i det korrekte format";
"gc.general.paymentProductFields.validationErrors.termsAndConditions.label" = "Du bedes acceptere vores vilkår og betingelser";
"gc.general.paymentProductFields.zip.label" = "Postnummer";
"gc.general.paymentProductFields.zip.placeholder" = "Postnummer";
Expand Down Expand Up @@ -434,6 +434,20 @@
"gc.general.paymentProducts.871.name" = "GCash";
"gc.general.paymentProducts.880.name" = "SafetyPay Banking";
"gc.general.paymentProducts.882.name" = "NetBanking";
"gc.general.paymentProducts.884.name" = "FPX";
"gc.general.paymentProducts.885.name" = "Maybank2u";
"gc.general.paymentProducts.886.name" = "CIMB Clicks";
"gc.general.paymentProducts.887.name" = "Bank Islam";
"gc.general.paymentProducts.888.name" = "RHB Now";
"gc.general.paymentProducts.889.name" = "AmOnline";
"gc.general.paymentProducts.890.name" = "Hong Leong Connect";
"gc.general.paymentProducts.891.name" = "PEx+ by HLBB";
"gc.general.paymentProducts.892.name" = "Affin Bank";
"gc.general.paymentProducts.893.name" = "Bangkok Bank";
"gc.general.paymentProducts.894.name" = "Krung Thai Bank";
"gc.general.paymentProducts.895.name" = "Siam Commercial Bank";
"gc.general.paymentProducts.896.name" = "Krungsri e_payment";
"gc.general.paymentProducts.897.name" = "Dragonpay RealTime";
"gc.general.paymentProducts.9000.name" = "AfterPay rater";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.label" = "Jeg accepterer {link} vilkår og betingelser";
"gc.general.paymentProducts.9000.paymentProductFields.termsAndConditions.link.label" = "AfterPay";
Expand Down
Loading

0 comments on commit 5f1adb4

Please sign in to comment.