Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a development mode #7

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Add a development mode #7

merged 3 commits into from
Feb 15, 2024

Conversation

AlasDiablo
Copy link
Collaborator

No description provided.

@parmentf
Copy link
Collaborator

parmentf commented Feb 14, 2024

I tried make run-dev, and it failed.
tdm-factory-dev-backend crashed:

tdm-factory-dev-backend   | 
tdm-factory-dev-backend   | > tdm-be@1.0.0 dev
tdm-factory-dev-backend   | > ts-node src/app.ts
tdm-factory-dev-backend   | 
tdm-factory-dev-backend   | 2024-02-14T15:45:39.021Z [default] error: No dynamic config file found
tdm-factory-dev-backend   | 2024-02-14T15:45:39.023Z [default] info: Dynamic config loaded
tdm-factory-dev-backend   | /app/node_modules/ts-node/src/index.ts:859
tdm-factory-dev-backend   |     return new TSError(diagnosticText, diagnosticCodes, diagnostics);
tdm-factory-dev-backend   |            ^
tdm-factory-dev-backend   | TSError: ⨯ Unable to compile TypeScript:
tdm-factory-dev-backend   | src/controller/webhook.ts(71,13): error TS2632: Cannot assign to 'currentTraitments' because it is an import.
tdm-factory-dev-backend   | 
tdm-factory-dev-backend   |     at createTSError (/app/node_modules/ts-node/src/index.ts:859:12)
tdm-factory-dev-backend   |     at reportTSError (/app/node_modules/ts-node/src/index.ts:863:19)
tdm-factory-dev-backend   |     at getOutput (/app/node_modules/ts-node/src/index.ts:1077:36)
tdm-factory-dev-backend   |     at Object.compile (/app/node_modules/ts-node/src/index.ts:1433:41)
tdm-factory-dev-backend   |     at Module.m._compile (/app/node_modules/ts-node/src/index.ts:1617:30)
tdm-factory-dev-backend   |     at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
tdm-factory-dev-backend   |     at Object.require.extensions.<computed> [as .ts] (/app/node_modules/ts-node/src/index.ts:1621:12)
tdm-factory-dev-backend   |     at Module.load (node:internal/modules/cjs/loader:1197:32)
tdm-factory-dev-backend   |     at Function.Module._load (node:internal/modules/cjs/loader:1013:12)
tdm-factory-dev-backend   |     at Module.require (node:internal/modules/cjs/loader:1225:19) {
tdm-factory-dev-backend   |   diagnosticCodes: [ 2632 ]
tdm-factory-dev-backend   | }

@AlasDiablo
Copy link
Collaborator Author

I tried make run-dev, and it failed. tdm-factory-dev-backend crashed:

tdm-factory-dev-backend   | 
tdm-factory-dev-backend   | > tdm-be@1.0.0 dev
tdm-factory-dev-backend   | > ts-node src/app.ts
tdm-factory-dev-backend   | 
tdm-factory-dev-backend   | 2024-02-14T15:45:39.021Z [default] error: No dynamic config file found
tdm-factory-dev-backend   | 2024-02-14T15:45:39.023Z [default] info: Dynamic config loaded
tdm-factory-dev-backend   | /app/node_modules/ts-node/src/index.ts:859
tdm-factory-dev-backend   |     return new TSError(diagnosticText, diagnosticCodes, diagnostics);
tdm-factory-dev-backend   |            ^
tdm-factory-dev-backend   | TSError: ⨯ Unable to compile TypeScript:
tdm-factory-dev-backend   | src/controller/webhook.ts(71,13): error TS2632: Cannot assign to 'currentTraitments' because it is an import.
tdm-factory-dev-backend   | 
tdm-factory-dev-backend   |     at createTSError (/app/node_modules/ts-node/src/index.ts:859:12)
tdm-factory-dev-backend   |     at reportTSError (/app/node_modules/ts-node/src/index.ts:863:19)
tdm-factory-dev-backend   |     at getOutput (/app/node_modules/ts-node/src/index.ts:1077:36)
tdm-factory-dev-backend   |     at Object.compile (/app/node_modules/ts-node/src/index.ts:1433:41)
tdm-factory-dev-backend   |     at Module.m._compile (/app/node_modules/ts-node/src/index.ts:1617:30)
tdm-factory-dev-backend   |     at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
tdm-factory-dev-backend   |     at Object.require.extensions.<computed> [as .ts] (/app/node_modules/ts-node/src/index.ts:1621:12)
tdm-factory-dev-backend   |     at Module.load (node:internal/modules/cjs/loader:1197:32)
tdm-factory-dev-backend   |     at Function.Module._load (node:internal/modules/cjs/loader:1013:12)
tdm-factory-dev-backend   |     at Module.require (node:internal/modules/cjs/loader:1225:19) {
tdm-factory-dev-backend   |   diagnosticCodes: [ 2632 ]
tdm-factory-dev-backend   | }

I have a fix, this crash is caused by a previous import reassign, but passing from require to import throw an error instade of creating side effect during runtime.

@parmentf
Copy link
Collaborator

Now, I can't populate the configuration...
image

@AlasDiablo AlasDiablo mentioned this pull request Feb 15, 2024
@parmentf parmentf merged commit d14128a into main Feb 15, 2024
1 of 2 checks passed
@parmentf parmentf deleted the feat/dev-mode branch February 15, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants