Multiple vec fixes that are useful to implement canvas_ity. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One problem with this PR, nogc_delete should only be called if ownsMemory is set at compile time (so that weak_vector doesn't free when it's not supposed to) |
…uite a bit of oddity in vector still. - Remove bizzarre idata() method, normally inout should not contaminate identifiers. Fixed that in strings, I supposed the goal was to not return mutable C string from numem string - vec.ptr() as alias to vec.data(), which is not inout. It fixed ref auto opOpAssign(string op = "~")(vector!T other) that uses other.ptr - vec.length as alias of vec.size - clear() and remove() will clean-up items in reverse manner just like the destructor, and only if not a basic type. - ref inout(T) opIndex. else you can't index vector fields in const methods - BREAKING remove is fixed (it was not possible to remove zero items with its API without crashing) and is now "delete [start, end)" instead of "delete [start, end]" Changed error recovery that swaps start and end to assertion. That makes the functions more similar in contract to c++ std::vector::erase and a bit more expected to me. IF the contract doesn't change, at least it should say plainly that this will crash if no items are removed.
|
Rebased and fixed that to account for yesterday changes. |
|
LGTM, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found quite a bit of oddities in vector still.
Remove bizzarre idata() method, normally inout should not contaminate identifiers. Fixed that in strings, I supposed the goal was to not return mutable C string from numem string
vec.ptr() as alias to vec.data(), which is now inout. It fixed
ref auto opOpAssign(string op = "~")(vector!T other)that usesother.ptrvec.lengthas alias ofvec.sizecompiler suggested that
vec.opDollarbeconstorinoutclear()andremove()will clean-up items in reverse manner just like the destructor, and only if not a basic type.ref inout(T) opIndex. else you can't index vector fields in const methods.BREAKING
vec.remove()is fixed (it was not possible to remove zero items with its API without crashing) and is now "delete [start, end)" instead of "delete [start, end]". Changed error recovery that swaps start and end to assertion. That makes the functions more similar in contract to c++std::vector::erase()and a bit more expected to me. IF the contract doesn't change, at least it should say plainly that this will crash if no items are removed.