[BUG] 🐛 $(userStorage) should not be accepted when us is null #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CChemin
force-pushed
the
controller-improve-tests
branch
4 times, most recently
from
239b236 to
d5e046e
Compare
CChemin
force-pushed
the
controller-improve-tests
branch
from
d5e046e to
2dc3405
Compare
| @@ -191,6 +191,7 @@ private List<String> getSearchRoleList( | |||
| } | |||
| return regexpList.stream() | |||
| .map(regexp -> StrSubstitutor.replace(regexp, valueMap, "$(", ")")) | |||
| .filter(role -> !role.matches(".*\\$(.*).*")) | |||
There was a problem hiding this comment.
in this expression parenthesis are not escaped (matching group expression), so the expression match
foo$foo and not only foo$(foo)foo
so any string with at least one $
Signed-off-by: CChemin <cecile.chemin@insee.fr>
Signed-off-by: CChemin <cecile.chemin@insee.fr>
CChemin
force-pushed
the
controller-improve-tests
branch
from
2dc3405 to
c0edaa9
Compare
… null Signed-off-by: CChemin <cecile.chemin@insee.fr>
CChemin
force-pushed
the
controller-improve-tests
branch
from
c0edaa9 to
f79f82e
Compare
clement-dufaure
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.