Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maintenance] androidContext readability #1655

Conversation

GrzegorzBobryk
Copy link
Contributor

@GrzegorzBobryk GrzegorzBobryk commented Sep 14, 2023

I have got second thoughts after previous pr. It was harder to read than it needed to be. I do not know if you care about such small things, but here is my proposition. :)

Improved readability by removing double usage of koin.loadModules(listOf(module {

@GrzegorzBobryk GrzegorzBobryk force-pushed the maintenance/androidContext_readability branch from 589daf1 to c1bffbf Compare October 9, 2023 15:36
@GrzegorzBobryk GrzegorzBobryk force-pushed the maintenance/androidContext_readability branch from c1bffbf to 7280f54 Compare December 28, 2023 21:56
@GrzegorzBobryk GrzegorzBobryk force-pushed the maintenance/androidContext_readability branch from 7280f54 to dc91050 Compare February 2, 2024 14:40
@GrzegorzBobryk GrzegorzBobryk force-pushed the maintenance/androidContext_readability branch from dc91050 to 482942a Compare June 3, 2024 07:52
Improved readability by removing double usage of `listOf` and `module`.
@arnaudgiuliani arnaudgiuliani changed the base branch from main to 3.6.0 July 15, 2024 07:11
@arnaudgiuliani
Copy link
Member

thanks @GrzegorzBobryk

@arnaudgiuliani arnaudgiuliani merged commit 5fb1d9b into InsertKoinIO:3.6.0 Jul 15, 2024
6 checks passed
@arnaudgiuliani arnaudgiuliani added this to the 3.6.0-Beta5 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants