Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Address valgrind defect in LabelErodeDilate #5258

Merged

Conversation

blowekamp
Copy link
Member

Update remote module to v1.3.1 hash to address valgrind defects.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

Update remote module to v1.3.1 hash to address valgrind defects.
@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances area:Remotes Issues affecting the Remote module labels Feb 26, 2025
@seanm
Copy link
Contributor

seanm commented Feb 26, 2025

If the valgrind faliure on cdash? I don't see it...

@blowekamp
Copy link
Member Author

blowekamp commented Feb 26, 2025

When I enabled it in SimpleITK it showed up there:
https://open.cdash.org/index.php?project=SimpleITK

The remote modules in ITK are of varying quality, and have not been enable in Doxygen, valgrind, and coverage. Here is a PR to update the ITK Valgrind build with the modules that are enabled in SimpleITK. These modules I have some motivation to support. If you wish to support additional remote modules they could be enabled too via a PR.
SimpleITK/SimpleITK#2250

@seanm
Copy link
Contributor

seanm commented Feb 26, 2025

Ah thanks. I was just curious what is issue was and if address sanitizer would also catch it. My bots don't build remote modules, so that explains it.

@blowekamp blowekamp marked this pull request as ready for review February 26, 2025 19:29
@blowekamp blowekamp merged commit 59d877d into InsightSoftwareConsortium:master Feb 26, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Remotes Issues affecting the Remote module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants