Skip to content

get all courses done #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 6, 2024
Merged

get all courses done #29

merged 11 commits into from
May 6, 2024

Conversation

IvanPPetrov02
Copy link
Contributor

No description provided.

Copy link
Contributor

@FelipeCarillo FelipeCarillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only need to add the unit tests, make only to presenter! if works the route is already tested!

@@ -0,0 +1,49 @@
import { it, describe, expect } from 'vitest';

import { handler } from '../../../../src/modules/auth_user/app/auth_user_presenter';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the right import!

this.course_repo = course_repo;
}

async execute(headers: { [key: string]: any }, queryStringParameters: { [key: string]: any }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove here the queryStringParameters, u are not using!

Comment on lines 32 to 36
if (!request.body) {
throw new InvalidRequest("Body");
}

const queryParams = request.body.queryStringParameters;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this all!

@FelipeCarillo FelipeCarillo merged commit 32e215e into dev May 6, 2024
@FelipeCarillo FelipeCarillo deleted the Get-All-Courses branch May 6, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants