Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump main to jazzy #225

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ RUN --mount=type=bind,source=.,target=/scenario_execution \
rm -rf /var/lib/apt/lists/*

RUN --mount=type=bind,source=.,target=/scenario_execution \
pip3 install --no-cache-dir -r /scenario_execution/libs/scenario_execution_pybullet/requirements.txt
pip3 install --no-cache-dir -r /scenario_execution/libs/scenario_execution_pybullet/requirements.txt --break-system-packages

# install rosbag2_to_video used within github actions
WORKDIR /rosbag2_to_video/src
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
name: Analyze (${{ matrix.language }})
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
container:
image: osrf/ros:humble-desktop-full
image: osrf/ros:jazzy-desktop-full
timeout-minutes: ${{ (matrix.language == 'swift' && 120) || 360 }}
permissions:
# required for all workflows
Expand Down Expand Up @@ -47,12 +47,12 @@ jobs:
- if: matrix.build-mode == 'manual'
shell: bash
run: |
source /opt/ros/humble/setup.bash
source /opt/ros/jazzy/setup.bash
colcon build --packages-up-to scenario_execution_interfaces
source install/setup.bash
apt update
rosdep update --rosdistro=humble
rosdep install --rosdistro=humble --from-paths scenario_execution_rviz --ignore-src -r -y;
rosdep update --rosdistro=jazzy
rosdep install --rosdistro=jazzy --from-paths scenario_execution_rviz --ignore-src -r -y;
mkdir build_rviz
cd build_rviz
cmake ../scenario_execution_rviz
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
push: true
tags: ghcr.io/intellabs/scenario-execution:${{ github.event.pull_request.base.ref || steps.extract_branch.outputs.branch }}
build-args: |
ROS_DISTRO=${{ github.ref == 'refs/heads/main' && 'humble' || github.event.pull_request.base.ref == 'main' && 'humble' || github.event.pull_request.base.ref }}
ROS_DISTRO=${{ github.ref == 'refs/heads/main' && 'jazzy' || github.event.pull_request.base.ref == 'main' && 'jazzy' || github.event.pull_request.base.ref }}
test-devcontainer:
runs-on: intellabs-01
permissions:
Expand All @@ -68,4 +68,4 @@ jobs:
file: .devcontainer/Dockerfile
push: false
build-args: |
ROS_DISTRO=${{ github.ref == 'refs/heads/main' && 'humble' || github.event.pull_request.base.ref == 'main' && 'humble' || github.event.pull_request.base.ref }}
ROS_DISTRO=${{ github.ref == 'refs/heads/main' && 'jazzy' || github.event.pull_request.base.ref == 'main' && 'jazzy' || github.event.pull_request.base.ref }}
4 changes: 2 additions & 2 deletions .github/workflows/scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
name: License check
runs-on: intellabs-01
container:
image: osrf/ros:humble-desktop
image: osrf/ros:jazzy-desktop
steps:
- name: Checkout code
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1
Expand All @@ -74,7 +74,7 @@
run: |
apt update
apt install -y python3-pip
pip3 install ros-license-toolkit==1.2.2
pip3 install --break-system-packages ros-license-toolkit==1.2.2

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 7: pipCommand not pinned by hash
Click Remediation section below to solve this issue
apt install -y golang-go
go version
go install github.com/google/addlicense@v1.1.1
Expand Down
60 changes: 32 additions & 28 deletions .github/workflows/test_build.yml

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions deb_requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
python3-autopep8
clang-format
pylint
cppzmq-dev
2 changes: 1 addition & 1 deletion docs/libraries.rst
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ Use MoveIt2 to move the end-effector to a specified pose, utilizing `MoveGroup a
.. list-table::
:widths: 15 15 5 65
:header-rows: 1
:class: tight-table
:class: tight-table

* - Parameter
- Type
Expand Down
4 changes: 2 additions & 2 deletions examples/example_moveit2/example_moveit2.osc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ scenario example_moveit2:
base_link: 'panda_link0')
do serial:
joint_pose: manipulator.move_to_joint_pose(
goal_pose: [+2.47, -0.57, -2.82, -1.37, 1.11, 1.44, 0.24],
goal_pose: [2.47, -0.57, -2.82, -1.37, 1.11, 1.44, 0.24],
move_group: move_group_type!arm)
open_gripper: manipulator.move_to_joint_pose(
goal_pose: [0.04, 0.04],
Expand All @@ -23,4 +23,4 @@ scenario example_moveit2:
goal_pose: [0.04, 0.04],
move_group: move_group_type!gripper)
wait elapsed(1s)
emit end
emit end
4 changes: 2 additions & 2 deletions examples/example_multi_robot/launch/robot2_launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ def generate_launch_description():
}],
arguments=[
[robot_name,
'/cmd_vel' + '@geometry_msgs/msg/Twist' + '[ignition.msgs.Twist'],
'/cmd_vel' + '@geometry_msgs/msg/Twist' + '[gz.msgs.Twist'],
['/model/', robot_name, '/cmd_vel' +
'@geometry_msgs/msg/Twist' +
']ignition.msgs.Twist']
']gz.msgs.Twist']
],
remappings=[
(['/model/', robot_name, '/cmd_vel'], [robot_name, '/cmd_vel'])
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def __init__(self):

def execute(self, entity_name: str, world_name: str): # pylint: disable=arguments-differ
self.entity_name = entity_name
self.set_command(["ign", "topic", "-t", "/world/" +
self.set_command(["gz", "topic", "-t", "/world/" +
world_name + "/pose/info", "-e", "--json-output"])

def on_executed(self):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ def __init__(self, associated_actor):
self.current_state = DeleteActionState.IDLE

def execute(self, associated_actor, entity_name: str, world_name: str): # pylint: disable=arguments-differ
self.set_command(["ign", "service", "-s", "/world/" + world_name + "/remove",
"--reqtype", "ignition.msgs.Entity",
"--reptype", "ignition.msgs.Boolean",
self.set_command(["gz", "service", "-s", "/world/" + world_name + "/remove",
"--reqtype", "gz.msgs.Entity",
"--reptype", "gz.msgs.Boolean",
"--timeout", "1000", "--req", "name: \"" + entity_name + "\" type: MODEL"])

def on_executed(self):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ def shutdown(self):
return

self.logger.info(f"Deleting entity '{self.entity_name}' from simulation.")
subprocess.run(["ign", "service", "-s", "/world/" + self.world_name + "/remove", # pylint: disable=subprocess-run-check
"--reqtype", "ignition.msgs.Entity",
"--reptype", "ignition.msgs.Boolean",
subprocess.run(["gz", "service", "-s", "/world/" + self.world_name + "/remove", # pylint: disable=subprocess-run-check
"--reqtype", "gz.msgs.Entity",
"--reptype", "gz.msgs.Boolean",
"--timeout", "1000", "--req", "name: \"" + self.entity_name + "\" type: MODEL"])

def on_process_finished(self, ret):
Expand Down Expand Up @@ -183,9 +183,9 @@ def set_command(self, command):
"""
pose = self.get_spawn_pose()

super().set_command(["ign", "service", "-s", "/world/" + self.world_name + "/create",
"--reqtype", "ignition.msgs.EntityFactory",
"--reptype", "ignition.msgs.Boolean",
super().set_command(["gz", "service", "-s", "/world/" + self.world_name + "/create",
"--reqtype", "gz.msgs.EntityFactory",
"--reptype", "gz.msgs.Boolean",
"--timeout", "30000", "--req", "pose: " + pose + " name: \"" + self.entity_name + "\" allow_renaming: false sdf: \"" + command + "\""])

def topic_callback(self, msg):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def __init__(self):
self.current_state = WaitForSimulationActionState.IDLE

def execute(self, world_name: str, timeout: int): # pylint: disable=arguments-differ
self.set_command(["ign", "topic", "-t", "/world/" +
self.set_command(["gz", "topic", "-t", "/world/" +
world_name + "/clock", "-e", "--json-output", "-n", "1"])
self.world_name = world_name
self.timeout_sec = timeout
Expand Down
2 changes: 1 addition & 1 deletion libs/scenario_execution_gazebo/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
],
install_requires=[
'setuptools',
'transforms3d==0.3.1',
'transforms3d==0.4.1',
'defusedxml==0.7.1',
],
zip_safe=True,
Expand Down
6 changes: 3 additions & 3 deletions scenario_execution/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@
],
install_requires=[
'setuptools',
'antlr4-python3-runtime==4.9.1',
'pyyaml>=5.4.1',
'py-trees==2.2.3'
'antlr4-python3-runtime==4.9.2',
'pyyaml==6.0.1',
'py-trees==2.2.1'
],
zip_safe=True,
include_package_data=True,
Expand Down
2 changes: 1 addition & 1 deletion scenario_execution_coverage/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
],
install_requires=[
'setuptools',
'pexpect==4.8.0',
'pexpect==4.9',
'defusedxml==0.7.1',
],
zip_safe=True,
Expand Down
2 changes: 1 addition & 1 deletion scenario_execution_ros/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
],
install_requires=[
'setuptools',
'transforms3d==0.3.1',
'transforms3d==0.4.1',
],
zip_safe=True,
maintainer='Intel Labs',
Expand Down
1 change: 1 addition & 0 deletions scenario_execution_ros/test/test_assert_tf_moving.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ def test_case_8(self):
self.execute(scenario_content)
self.assertFalse(self.scenario_execution_ros.process_results())

@unittest.skip(reason="unstable on CI")
def test_case_9(self):
scenario_content = """
import osc.ros
Expand Down
2 changes: 1 addition & 1 deletion scenario_execution_rviz/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ project(scenario_execution_rviz)
set(CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_STANDARD 14)

add_compile_options(-Wall -Wextra -Werror -flto -fvisibility=hidden -z noexecstac -fPIC -D_FORTIFY_SOURCE=2 -Wl,-z,relro,-z,now -fstack-protector-strong)
add_compile_options(-Wall -Wextra -Werror -flto -fvisibility=hidden -z noexecstac -fPIC -Wl,-z,relro,-z,now -fstack-protector-strong)

find_package(ament_cmake REQUIRED)
find_package(rviz_common REQUIRED)
Expand Down
3 changes: 1 addition & 2 deletions simulation/gazebo/arm_sim_scenario/config/control.urdf.xacro
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@
<joint name="panda_finger_joint2">
<param name="mimic">panda_finger_joint1</param>
<param name="multiplier">1</param>
<command_interface name="position"/>
<state_interface name="position">
<param name="initial_value">0.01</param>
</state_interface>
Expand All @@ -82,7 +81,7 @@

<xacro:if value="${ros2_control_hardware_type == 'ignition'}">
<gazebo>
<plugin filename="libign_ros2_control-system.so" name="ign_ros2_control::IgnitionROS2ControlPlugin">
<plugin filename="libgz_ros2_control-system.so" name="ign_ros2_control::IgnitionROS2ControlPlugin">
<robot_param>robot_description</robot_param>
<robot_param_node>robot_state_publisher</robot_param_node>
<parameters>$(find moveit_resources_panda_moveit_config)/config/ros2_controllers.yaml</parameters>
Expand Down
Loading
Loading