Implements statistical functions mean, std, var
#1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1465/index.html |
|
Array API standard conformance tests for dpctl=0.15.1dev1=py310ha25a700_5 ran successfully. |
|
Array API standard conformance tests for dpctl=0.15.1dev1=py310ha25a700_6 ran successfully. |
oleksandr-pavlyk
previously approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Other than the suggestion, this looks great @ndgrigorian ! Thank you for working on implementing these functions.
6 tasks
ndgrigorian
force-pushed
the
statistical-functions
branch
from
116be9f to
19ffc5f
Compare
|
Array API standard conformance tests for dpctl=0.15.1dev1=py310ha25a700_17 ran successfully. |
oleksandr-pavlyk
previously approved these changes
Nov 8, 2023
Tree reductions now populate destination with the identity when reducing over zero-size axes. As a result, logic was removed for handling zero-size axes. ``argmax``, ``argmin``, ``max``, and ``min`` still raise an error for zero-size axes. Reductions now return a copy when provided an empty axis tuple. Adds additional supported dtype combinations to ``prod`` and ``sum``, specifically for input integers and inexact output type
Permits `float` accumulation type with 64 bit integer and unsigned integer inouts to prevent unnecessary copies on devices that don't support double precision
Mean in-place division now uses the real type for the denominator
ndgrigorian
force-pushed
the
statistical-functions
branch
from
19ffc5f to
9253931
Compare
oleksandr-pavlyk
approved these changes
Nov 8, 2023
|
Array API standard conformance tests for dpctl=0.15.1dev1=py310ha25a700_18 ran successfully. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
Implements
dpctl.tensor.mean,dpctl.tensor.std, anddpctl.tensor.varas top-level functions which leverage tensor submodules.Resolves dpctl does not return a zero-length array when no reduction is going to be done #1456 by adding logic to tree reduction implementations that populate the output array with the identity when reducing over axes which include a zero-size axis and by adding early exits for
py_reduction_over_axis,py_tree_reduction_over_axis, andpy_search_over_axiswhen the destination array is of zero size.This permitted removing
identityas an argument to the general reduction Python API, as well as removing logic for zero-size array inputs.Adjusts reduction Python API functions to return a copy of the input array, rather than the input array itself, when no reduction will be performed (i.e.,
axis=())Adds additional supported type combinations to
sumandprodreductions. Prior to Implementsdpctl.tensor.logsumexpanddpctl.tensor.reduce_hypot#1446 , reductions overintinputs withfloatoutputs had dedicated kernels when using atomics to avoid a copy. This pull request adds these type combinations for tree reductions.