Skip to content

Revert gh-2251#2261

Merged
ndgrigorian merged 4 commits intomasterfrom
revert-gh-2251
Mar 9, 2026
Merged

Revert gh-2251#2261
ndgrigorian merged 4 commits intomasterfrom
revert-gh-2251

Conversation

@ndgrigorian
Copy link
Collaborator

This PR reverts gh-2251, which dropped use of setup Miniconda action's activate-environment due to warnings that claimed the environment didn't exist

These warnings were not reflective of the creation of the environment. Since it does get created, the better approach is to ignore these warnings.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

drops conda activate commands
@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_22 ran successfully.
Passed: 1246
Failed: 42
Skipped: 89

@coveralls
Copy link
Collaborator

coveralls commented Mar 9, 2026

Coverage Status

coverage: 86.248%. remained the same
when pulling 5c06579 on revert-gh-2251
into db0d55e on master.

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_23 ran successfully.
Passed: 1245
Failed: 43
Skipped: 89

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_23 ran successfully.
Passed: 1245
Failed: 43
Skipped: 89

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_24 ran successfully.
Passed: 1243
Failed: 45
Skipped: 89

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_25 ran successfully.
Passed: 1245
Failed: 43
Skipped: 89

@ndgrigorian ndgrigorian merged commit 7f90c80 into master Mar 9, 2026
46 of 64 checks passed
@ndgrigorian ndgrigorian deleted the revert-gh-2251 branch March 9, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants