Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove skip test #1629

Merged
merged 1 commit into from
Nov 23, 2023
Merged

remove skip test #1629

merged 1 commit into from
Nov 23, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Nov 23, 2023

A skip test is removed since dpctl issue #1468 is resolved by dpctl PR #1470.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Nov 23, 2023
@vtavana vtavana requested a review from antonwolfy November 23, 2023 19:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for keeping track of that @vtavana

@vtavana vtavana merged commit 0604f18 into master Nov 23, 2023
22 checks passed
@vtavana vtavana deleted the remove_skip_test branch November 23, 2023 23:43
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy