Implement dpnp.isin
#2595
Draft
Implement dpnp.isin
#2595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndgrigorian
force-pushed
the
reuse-tensor-isin
branch
from
de4e3bb to
df81181
Compare
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2595/index.html |
|
Array API standard conformance tests for dpnp=0.19.0dev6=py313h509198e_5 ran successfully. |
antonwolfy
reviewed
Oct 9, 2025
| return a.flags.fnc | ||
|
|
||
|
|
||
| def isin(element, test_elements, assume_unique=False, invert=False): |
There was a problem hiding this comment.
NumPy supports also kind keyword, but we can limit it with only None and 'sort' values and state a limitation that 'table' is not supported
Suggested change
| def isin(element, test_elements, assume_unique=False, invert=False): | |
| def isin(element, test_elements, assume_unique=False, invert=False, *, kind=None): |
| def isin(element, test_elements, assume_unique=False, invert=False): | ||
| """ | ||
| Calculates ``element in test_elements``, broadcasting over `element` only. | ||
| Returns a boolean array of the same shape as `element` that is True |
There was a problem hiding this comment.
Suggested change
| Returns a boolean array of the same shape as `element` that is True | |
| Returns a boolean array of the same shape as `element` that is ``True`` |
| """ | ||
| Calculates ``element in test_elements``, broadcasting over `element` only. | ||
| Returns a boolean array of the same shape as `element` that is True | ||
| where an element of `element` is in `test_elements` and False otherwise. |
There was a problem hiding this comment.
Suggested change
| where an element of `element` is in `test_elements` and False otherwise. | |
| where an element of `element` is in `test_elements` and ``False`` otherwise. |
| Calculates ``element in test_elements``, broadcasting over `element` only. | ||
| Returns a boolean array of the same shape as `element` that is True | ||
| where an element of `element` is in `test_elements` and False otherwise. | ||
There was a problem hiding this comment.
Suggested change
| For full documentation refer to :obj:`numpy.isin`. | |
| Parameters | ||
| ---------- | ||
| element : {array_like, dpnp.ndarray, usm_ndarray} |
There was a problem hiding this comment.
Suggested change
| element : {array_like, dpnp.ndarray, usm_ndarray} | |
| element : {dpnp.ndarray, usm_ndarray, scalar} |
| This argument is flattened if it is an array or array_like. | ||
| See notes for behavior with non-array-like parameters. | ||
| assume_unique : bool, optional | ||
| Ignored |
There was a problem hiding this comment.
It'd be great to add more words
| calculating `element not in test_elements`. Default is False. | ||
| ``dpnp.isin(a, b, invert=True)`` is equivalent to (but faster | ||
| than) ``dpnp.invert(dpnp.isin(a, b))``. | ||
There was a problem hiding this comment.
Suggested change
| Default: ``False``. | |
Comment on lines
+1136
to
+1137
| If True, the values in the returned array are inverted, as if | ||
| calculating `element not in test_elements`. Default is False. |
There was a problem hiding this comment.
Suggested change
| If True, the values in the returned array are inverted, as if | |
| calculating `element not in test_elements`. Default is False. | |
| If ``True``, the values in the returned array are inverted, as if | |
| calculating `element not in test_elements`. |
| dpt.isin( | ||
| usm_element, | ||
| usm_test, | ||
| assume_unique=assume_unique, |
There was a problem hiding this comment.
dpctl does not have that keyword
Suggested change
| assume_unique=assume_unique, |
Comment on lines
+1181
to
+1197
| if dpnp.isscalar(element): | ||
| usm_element = dpt.asarray( | ||
| element, | ||
| sycl_queue=test_elements.sycl_queue, | ||
| usm_type=test_elements.usm_type, | ||
| ) | ||
| usm_test = dpnp.get_usm_ndarray(test_elements) | ||
| elif dpnp.isscalar(test_elements): | ||
| usm_test = dpt.asarray( | ||
| test_elements, | ||
| sycl_queue=element.sycl_queue, | ||
| usm_type=element.usm_type, | ||
| ) | ||
| usm_element = dpnp.get_usm_ndarray(element) | ||
| else: | ||
| usm_element = dpnp.get_usm_ndarray(element) | ||
| usm_test = dpnp.get_usm_ndarray(test_elements) |
There was a problem hiding this comment.
Suggested change
| if dpnp.isscalar(element): | |
| usm_element = dpt.asarray( | |
| element, | |
| sycl_queue=test_elements.sycl_queue, | |
| usm_type=test_elements.usm_type, | |
| ) | |
| usm_test = dpnp.get_usm_ndarray(test_elements) | |
| elif dpnp.isscalar(test_elements): | |
| usm_test = dpt.asarray( | |
| test_elements, | |
| sycl_queue=element.sycl_queue, | |
| usm_type=element.usm_type, | |
| ) | |
| usm_element = dpnp.get_usm_ndarray(element) | |
| else: | |
| usm_element = dpnp.get_usm_ndarray(element) | |
| usm_test = dpnp.get_usm_ndarray(test_elements) | |
| usm_element = dpnp.as_usm_ndarray(element, usm_type=test_elements.usm_type, sycl_queue=test_elements.sycl_queue) | |
| usm_test = dpnp.as_usm_ndarray(test_elements, usm_type=element.usm_type, sycl_queue=element.sycl_queue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the recently-added
dpctl.tensor.isinto implementdpnp.isin