Use default nbt when parsing blocks #2945
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreSchwang
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Looks good I guess.
I think we should apply upstream changes rather sooner than later, so that NBT data can be specified as well - so that would probably address that as well, kind of (https://worldedit.enginehub.org/en/latest/usage/general/patterns/#single-block-pattern)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #2944
Description
Not setting the block with its default NBT data results in the (vanilla) client not rendering the blocks properly. We should also probably pull upstream changes in that area at some point, but that didn't look as straightforward as this fix.
Submitter Checklist