Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable module autoload #86

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Disable module autoload #86

wants to merge 10 commits into from

Conversation

rzkhrv
Copy link

@rzkhrv rzkhrv commented Mar 29, 2024

This change resolves the problem of autoloading files for modules that are not in the composer.json.

@inxilpro
Copy link
Contributor

inxilpro commented Apr 3, 2024

@rzkhrv can you explain why you would want this?

@rzkhrv
Copy link
Author

rzkhrv commented Apr 3, 2024

Hi @inxilpro, my case is when I remove a module from composer.json I get some errors...

@inxilpro
Copy link
Contributor

inxilpro commented Apr 6, 2024

Oh cool. Can you think of any reason this shouldn't just be the default? I don't know that we even need a config flag…

@rzkhrv
Copy link
Author

rzkhrv commented Apr 8, 2024

I don't have any reason, basically we can remove the config flag

@princejohnsantillan
Copy link

I agree. Feels like should be the default. I like this change.

rzkhrv added 2 commits April 27, 2024 18:26
# Conflicts:
#	config.php
#	src/Support/AutoDiscoveryHelper.php
@rzkhrv
Copy link
Author

rzkhrv commented Apr 27, 2024

Hi @inxilpro, I did it but my IDE doesn't want to format the code, can you help me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants