Specify language in scraper so it doesn't look for the wrong thing #195
Conversation
|
Comment by @jacob-g "While I don't think this is likely to be a problem, I suppose it doesn't hurt to be safe. I'll validate this when I get the chance." |
|
Closes #191 |
| @@ -8,7 +8,9 @@ class ScratchUserCheck { | |||
|
|
|||
| private static function fetchProfile($username, &$isScratcher, &$joinedAt, &$error) { | |||
| $url = sprintf(self::PROFILE_URL, $username); | |||
| $html = @file_get_contents($url); | |||
| $html = @file_get_contents($url, false, stream_context_create( | |||
There was a problem hiding this comment.
Make sure to wrap the outer part of the array properly. I believe it should be:
stream_context_create([
"http" => ["header" => "Accept-Language: en\r\nCookie: scratchlanguage=en"]
])Also a more minor detail: single quotes are preferred over double quotes unless you are specifically intending to use variable interpolation or escape sequences.
|
@jacob-g Might be web server-specific. Added your changes |
| "http" => ["header" => "Accept-Language: en\r\nCookie: scratchlanguage=en"] | ||
| )); | ||
| $html = @file_get_contents($url, false, stream_context_create([ | ||
| 'http' => ['header' => 'Accept-Language: en\r\nCookie: scratchlanguage=en'] |
There was a problem hiding this comment.
I suppose I should have been clearer with the single quotes: it's right for http and header, but for the body you actually do want double quotes due to the use of \r and \n.
|
Other than the quote thing, looks good now. Fix that and we're good to go. |
|
OK, now? |
This is a copy of #192 which was mistakenly closed by deleting the fork that the code was in.
Original text:
"Depending on a web server's configuration or location, it may get back a response with a language besides English, breaking the scraper. This fixes that.
This does not currently affect en.scratch-wiki.info because it doesn't put an Accept-Language header by default, and Scratch ignores IP addresses, but it will affect other web servers and may affect en.scratch-wiki.info as well should either of the two aforementioned things change."
Closes #191